Skip to content

[Build] Fix version regex to anchor at line start in pyproject.toml#18892

Merged
tqchen merged 1 commit into
apache:mainfrom
MasterJH5574:tvm-dev/2026-03-09-version
Mar 9, 2026
Merged

[Build] Fix version regex to anchor at line start in pyproject.toml#18892
tqchen merged 1 commit into
apache:mainfrom
MasterJH5574:tvm-dev/2026-03-09-version

Conversation

@MasterJH5574

Copy link
Copy Markdown
Contributor

Add ^ anchor to the version regex so it matches only the top-level version = "..." instead of all three occurrences, which caused hit_count == 3 and a RuntimeError in sync_version.

Add ^ anchor to the version regex so it matches only the top-level
`version = "..."` instead of all three occurrences, which caused
hit_count == 3 and a RuntimeError in sync_version.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical build issue where the version synchronization script failed due to an overly broad regular expression. The change refines the regex used to update the project version in pyproject.toml, ensuring that only the primary version declaration is targeted, thereby preventing erroneous multiple matches and associated runtime errors.

Highlights

  • Regex Fix: Modified the version regex in version.py to include a ^ anchor, ensuring it only matches the top-level version = "..." entry in pyproject.toml. This prevents incorrect multiple matches and a RuntimeError during version synchronization.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • version.py
    • Anchored the version regex to the start of the line to prevent multiple matches.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue in the version synchronization script where the regular expression for updating pyproject.toml was not specific enough, potentially matching incorrect lines. The change anchors the regex to the start of the line, which is a good fix. My review includes a suggestion to further improve the regex's robustness by accounting for variable whitespace, which is allowed in the TOML format.

Comment thread version.py
@tqchen tqchen merged commit 728eb15 into apache:main Mar 9, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants