[Build] Fix version regex to anchor at line start in pyproject.toml#18892
Conversation
Add ^ anchor to the version regex so it matches only the top-level `version = "..."` instead of all three occurrences, which caused hit_count == 3 and a RuntimeError in sync_version.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical build issue where the version synchronization script failed due to an overly broad regular expression. The change refines the regex used to update the project version in Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses an issue in the version synchronization script where the regular expression for updating pyproject.toml was not specific enough, potentially matching incorrect lines. The change anchors the regex to the start of the line, which is a good fix. My review includes a suggestion to further improve the regex's robustness by accounting for variable whitespace, which is allowed in the TOML format.
Add ^ anchor to the version regex so it matches only the top-level
version = "..."instead of all three occurrences, which caused hit_count == 3 and a RuntimeError in sync_version.