[REFACTOR][CONTRIB] Remove MSC contrib module#18845
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant refactoring effort to streamline the TVM project by completely excising the Multi-System Compiler (MSC) contrib module. This removal addresses a self-contained and unused component, leading to a substantial reduction in code volume and simplifying the overall project structure. The changes primarily involve deleting all associated source files, build configurations, and Python package references, ensuring a clean and isolated removal. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a significant refactoring that completely removes the MSC (Multi-System Compiler) contrib module. The changes are extensive, deleting over 200 files and approximately 57,500 lines of code. The modifications to the build system files (CMakeLists.txt, cmake/config.cmake, etc.) and project configuration (pyproject.toml) correctly remove all references and build options related to MSC. This is a valuable cleanup that simplifies the codebase. The changes appear to be correct and align with the goal of removing the self-contained module.
Remove the Multi-System Compiler (MSC) contrib module including all Python source, C++ source, runtime, tests, CMake build integration, and configuration references.
de7b7c3 to
bc11050
Compare
Summary
Remove the MSC (Multi-System Compiler) contrib module. MSC is entirely self-contained with zero cross-references from core TVM.