[REFACTOR] Update CHECK and ICHECK_GE to TVM_FFI_ICHECK and TVM_FFI_ICHECK_GE in thrust.cu

[babusid]

Main branch failed to build due to old macro in the thrust.cu file. This PR brings it up to speed.

[gemini-code-assist]

Summary of Changes

Hello @babusid, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical build failure by updating outdated macro usages within the thrust.cu file. The changes ensure that the thrust backend correctly utilizes the current TVM FFI checking macros, thereby restoring build integrity and maintaining compatibility with the latest codebase standards.

Highlights

• Build Fix: Resolved a build failure on the main branch by updating deprecated CHECK and ICHECK macros to TVM_FFI_ICHECK within the src/runtime/contrib/thrust/thrust.cu file.
• Macro Refactor: Replaced all instances of the older CHECK and ICHECK macros with the new TVM_FFI_ICHECK macro family to ensure consistency and adherence to current TVM FFI checking standards.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/runtime/contrib/thrust/thrust.cu
  • Replaced CHECK with TVM_FFI_ICHECK in the WorkspaceMemoryResource constructor.
  • Replaced CHECK with TVM_FFI_ICHECK in the WorkspaceMemoryResource::do_allocate method.
  • Updated ICHECK_GE to TVM_FFI_ICHECK_GE in the tvm.contrib.thrust.sort packed function registration.
  • Updated ICHECK_GE to TVM_FFI_ICHECK_GE in the tvm.contrib.thrust.stable_sort_by_key packed function registration.
  • Updated ICHECK to TVM_FFI_ICHECK in the tvm.contrib.thrust.sum_scan packed function registration.

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a build failure by refactoring outdated CHECK and ICHECK macros to their TVM_FFI_ counterparts in thrust.cu. The changes are correct and necessary. I've added a few suggestions to make the argument validation checks at the FFI boundaries more precise, which can improve robustness by catching incorrect API usage. Overall, this is a good fix.

[tqchen]

thanks @babusid please fix the lint issue

[babusid]

thanks @babusid please fix the lint issue

done!