[REFACTOR][RUNTIME] Phase out legacy contrib runtime backends#18813
Conversation
This PR removes 9 stale/dead contrib runtime backends that have no active development or test coverage: Tier 4 (dead code): arm_compute_lib, bnns, edgetpu, tflite Tier 3 (stale): miopen, mrvl, rocblas, mps, papi For each backend, removes: src/runtime/contrib/<name>/, cmake modules, CMake config options, Python contrib wrappers, test files, and include headers. Also cleans up references in LibInfo, ROCM.cmake, Metal.cmake, FindROCM.cmake, and the Python profiling module.
Summary of ChangesHello @tqchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant refactoring effort by phasing out a collection of legacy runtime backends. The primary goal is to reduce technical debt and simplify the codebase by removing components that are no longer actively developed, lack compiler integration, or have minimal test coverage. This cleanup impacts various parts of the system, from build configurations to documentation, ensuring a more focused and maintainable project moving forward. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully phases out several legacy contrib runtime backends, including arm_compute_lib, bnns, edgetpu, tflite, miopen, mps, mrvl, rocblas, and papi. These backends were identified as having no Relax compiler support, no active development, and minimal test coverage. The removal is thorough, spanning CMake build configurations, library information reporting, Python contrib modules, runtime C++ implementations, and associated tests. The changes are consistent and correctly decouple these deprecated components from the TVM ecosystem.
2 participants
This PR removes legacy runtime contrib backends that have no existing compiler backend,
no active development. They can always be brought back in future in case we find there is a need