[Refactor][Metal] Update ICHECK to TVM_FFI_ICHECK in Metal runtime#18811
Conversation
This commit updates all ICHECK macros to TVM_FFI_ICHECK in the Metal runtime implementation to align with the new FFI refactoring. The changes include updating ICHECK, ICHECK_LT, ICHECK_EQ macros to their TVM_FFI_ICHECK equivalents across the following files: - src/runtime/metal/metal_device_api.mm - src/runtime/metal/metal_module.mm This refactoring ensures consistency with the new TVM FFI interface and maintains the same error checking behavior while using the updated macro names.
Summary of ChangesHello @ballinyouup, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Metal runtime implementation to align with recent FFI changes. It systematically updates all instances of the older ICHECK macro family to the new TVM_FFI_ICHECK equivalents, ensuring consistency with the updated FFI interface while preserving the existing error checking logic. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request performs a refactoring in the Metal runtime to replace ICHECK macros with their TVM_FFI_ICHECK counterparts. The changes are applied across src/runtime/metal/metal_device_api.mm and src/runtime/metal/metal_module.mm. This update aligns the codebase with the new FFI refactoring, ensuring consistency. The changes are straightforward and correct, maintaining the existing error-checking logic. The pull request is good to merge.
|
you can run by pre-commit run --all-files |
2 participants
This commit updates all ICHECK macros to TVM_FFI_ICHECK in the Metal runtime implementation to align with the new FFI refactoring.
The changes include updating ICHECK, ICHECK_LT, ICHECK_EQ macros to their TVM_FFI_ICHECK equivalents across the following files:
This refactoring ensures consistency with the new TVM FFI interface and maintains the same error checking behavior while using the updated macro names.