[REFACTOR][LINT] Modernize ruff config#18810
Merged
Merged
Conversation
Contributor
Summary of ChangesHello @tqchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly modernizes the TVM codebase's linting infrastructure by updating the ruff configuration, fixing numerous linting violations, and removing legacy pylint directives. The changes promote cleaner, more modern Python syntax, particularly with type hints and string formatting, enhancing code readability and maintainability across a large number of files. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modernizes the TVM codebase by updating the Ruff configuration to target Python 3.10 and adopting modern type hint syntax (PEP 585 and PEP 604). The addition of from __future__ import annotations across the codebase is a significant improvement for maintainability. However, while the PR fixes many lint violations, it also introduces extensive directory-wide suppressions in pyproject.toml for critical rules like E722 (bare except). This review highlights opportunities to replace these bare excepts with safer alternatives and to remove redundant lambda functions in transformation passes.
tqchen
changed the title
tqchen
force-pushed
the
ruff-lint-cleanup
branch
10 times, most recently
from
8d90cb7 to
d6f01b5
Compare
Member
Author
|
@tvm-bot rerun |
tqchen
force-pushed
the
ruff-lint-cleanup
branch
from
d6f01b5 to
1cea8e0
Compare
Member
Author
|
@tvm-bot rerun |
tqchen
force-pushed
the
ruff-lint-cleanup
branch
from
d8995b4 to
3a09937
Compare
guan404ming
approved these changes
Feb 23, 2026
tqchen
force-pushed
the
ruff-lint-cleanup
branch
5 times, most recently
from
cd5f289 to
763f145
Compare
This PR modernizes the ruff linting configuration for TVM: - Remove broad global rule ignores from pyproject.toml - Move suppressed lint rules to per-file `# ruff: noqa:` comments - Keep only `__init__.py` per-file-ignores in pyproject.toml - Global ignores limited to UP006/UP007/UP035/UP045 (need future annotations) and RUF043/RUF059 (preview rules)
tqchen
force-pushed
the
ruff-lint-cleanup
branch
from
763f145 to
b93f803
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the extra lint violations from the codebase so lint aligns with the latest style