[CI] Add GitHub Actions lint workflow#18809
Merged
Merged
Conversation
Contributor
Summary of ChangesHello @tqchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the continuous integration pipeline by transitioning the linting process from a Jenkins-based system to a GitHub Actions workflow. This change aims to streamline the development process by integrating lint checks directly into the GitHub platform, making them more accessible and efficient for contributors. It also updates project dependencies to support the new linting setup. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request aims to transition linting from Jenkins to GitHub Actions. However, the GitHub Actions workflow file itself is missing from the provided changes, which is the core part of the PR. Additionally, removing the mandatory lint check in .asf.yaml without adding the new GitHub Actions check name reduces CI enforcement. In pyproject.toml, the new dependency-groups section is redundant as pre-commit is already defined in optional-dependencies. Please ensure the GHA workflow is included and the status checks are correctly updated.
tqchen
force-pushed
the
gh-lint-workflow
branch
from
b601a48 to
6724aa5
Compare
This PR adds a GitHub Actions workflow that runs pre-commit hooks and removes the need on jenkins to do lint
tqchen
force-pushed
the
gh-lint-workflow
branch
from
6724aa5 to
c4d955b
Compare
MasterJH5574
added a commit
to MasterJH5574/mlc-llm
that referenced
this pull request
Apr 19, 2026
Mirror the TVM setup (apache/tvm#18809): a minimal GHA workflow that runs `uv sync --group lint` plus `pre-commit/action`. Pre-commit is rewritten around ruff (check + format), replacing the previous isort/black/mypy/pylint/cmake-format stack, and gains yamllint, taplo, check-yaml, and check-toml. The corresponding Jenkins Lint stage, the ci/task/{isort,black,mypy,pylint,clang-format}.sh scripts, and .pylintrc are removed. pyproject.toml grows a [tool.ruff] section (select E/F/I/UP/RUF, line-length 100, py39 target) and a [dependency-groups] lint entry; the stale isort/black/mypy/pylint tool tables are dropped. To get the codebase green under the new ruler, existing UP006/UP035/ UP045/E501/RUF001/RUF002/E402/F821 violations are grandfathered via inline `# noqa`, so new code in those forms is still flagged. Real issues surfaced by the new rules are fixed directly: E741 renames (ambiguous `l`/`O`), F841 unused locals, E722 bare `except`, RUF012 ClassVar annotations for mutable class defaults, RUF013 explicit `Optional[...]`, and RUF005 iterable unpacking. With pylint and mypy gone from CI, this also strips all `# pylint: disable/enable` and `# type: ignore` directives from Python sources (PEP 484 `# type: <expr>` comments and `# fmt: off/on` are preserved), and runs the resulting files through ruff-format.
MasterJH5574
added a commit
to MasterJH5574/mlc-llm
that referenced
this pull request
Apr 19, 2026
Mirror the TVM setup (apache/tvm#18809): a minimal GHA workflow that runs `uv sync --group lint` plus `pre-commit/action`. Pre-commit is rewritten around ruff (check + format), replacing the previous isort/black/mypy/pylint/cmake-format stack, and gains yamllint, taplo, check-yaml, and check-toml. The corresponding Jenkins Lint stage, the ci/task/{isort,black,mypy,pylint,clang-format}.sh scripts, and .pylintrc are removed. pyproject.toml grows a [tool.ruff] section (select E/F/I/UP/RUF, line-length 100, py39 target) and a [dependency-groups] lint entry; the stale isort/black/mypy/pylint tool tables are dropped. To get the codebase green under the new ruler, existing UP006/UP035/ UP045/E501/RUF001/RUF002/E402/F821 violations are grandfathered via inline `# noqa`, so new code in those forms is still flagged. Real issues surfaced by the new rules are fixed directly: E741 renames (ambiguous `l`/`O`), F841 unused locals, E722 bare `except`, RUF012 ClassVar annotations for mutable class defaults, RUF013 explicit `Optional[...]`, and RUF005 iterable unpacking. With pylint and mypy gone from CI, this also strips all `# pylint: disable/enable` and `# type: ignore` directives from Python sources (PEP 484 `# type: <expr>` comments and `# fmt: off/on` are preserved), and runs the resulting files through ruff-format.
MasterJH5574
added a commit
to MasterJH5574/mlc-llm
that referenced
this pull request
Apr 19, 2026
Mirror the TVM setup (apache/tvm#18809): a minimal GHA workflow that runs `uv sync --group lint` plus `pre-commit/action`. Pre-commit is rewritten around ruff (check + format), replacing the previous isort/black/mypy/pylint/cmake-format stack, and gains yamllint, taplo, check-yaml, and check-toml. The corresponding Jenkins Lint stage, the ci/task/{isort,black,mypy,pylint,clang-format}.sh scripts, and .pylintrc are removed. pyproject.toml grows a [tool.ruff] section (select E/F/I/UP/RUF, line-length 100, py39 target) and a [dependency-groups] lint entry; the stale isort/black/mypy/pylint tool tables are dropped. To get the codebase green under the new ruler, existing UP006/UP035/ UP045/E501/RUF001/RUF002/E402/F821 violations are grandfathered via inline `# noqa`, so new code in those forms is still flagged. Real issues surfaced by the new rules are fixed directly: E741 renames (ambiguous `l`/`O`), F841 unused locals, E722 bare `except`, RUF012 ClassVar annotations for mutable class defaults, RUF013 explicit `Optional[...]`, and RUF005 iterable unpacking. With pylint and mypy gone from CI, this also strips all `# pylint: disable/enable` and `# type: ignore` directives from Python sources (PEP 484 `# type: <expr>` comments and `# fmt: off/on` are preserved), and runs the resulting files through ruff-format.
MasterJH5574
added a commit
to MasterJH5574/mlc-llm
that referenced
this pull request
Apr 20, 2026
Mirror the TVM setup (apache/tvm#18809): a minimal GHA workflow that runs `uv sync --group lint` plus `pre-commit/action`. Pre-commit is rewritten around ruff (check + format), replacing the previous isort/black/mypy/pylint/cmake-format stack, and gains yamllint, taplo, check-yaml, and check-toml. The corresponding Jenkins Lint stage, the ci/task/{isort,black,mypy,pylint,clang-format}.sh scripts, and .pylintrc are removed. pyproject.toml grows a [tool.ruff] section (select E/F/I/UP/RUF, line-length 100, py39 target) and a [dependency-groups] lint entry; the stale isort/black/mypy/pylint tool tables are dropped. To get the codebase green under the new ruler, existing UP006/UP035/ UP045/E501/RUF001/RUF002/E402/F821 violations are grandfathered via inline `# noqa`, so new code in those forms is still flagged. Real issues surfaced by the new rules are fixed directly: E741 renames (ambiguous `l`/`O`), F841 unused locals, E722 bare `except`, RUF012 ClassVar annotations for mutable class defaults, RUF013 explicit `Optional[...]`, and RUF005 iterable unpacking. With pylint and mypy gone from CI, this also strips all `# pylint: disable/enable` and `# type: ignore` directives from Python sources (PEP 484 `# type: <expr>` comments and `# fmt: off/on` are preserved), and runs the resulting files through ruff-format.
MasterJH5574
added a commit
to MasterJH5574/mlc-llm
that referenced
this pull request
Apr 20, 2026
Mirror the TVM setup (apache/tvm#18809): a minimal GHA workflow that runs `uv sync --group lint` plus `pre-commit/action`. Pre-commit is rewritten around ruff (check + format), replacing the previous isort/black/mypy/pylint/cmake-format stack, and gains yamllint, taplo, check-yaml, and check-toml. The corresponding Jenkins Lint stage, the ci/task/{isort,black,mypy,pylint,clang-format}.sh scripts, and .pylintrc are removed. pyproject.toml grows a [tool.ruff] section (select E/F/I/UP/RUF, line-length 100, py39 target) and a [dependency-groups] lint entry; the stale isort/black/mypy/pylint tool tables are dropped. To get the codebase green under the new ruler, existing UP006/UP035/ UP045/E501/RUF001/RUF002/E402/F821 violations are grandfathered via inline `# noqa`, so new code in those forms is still flagged. Real issues surfaced by the new rules are fixed directly: E741 renames (ambiguous `l`/`O`), F841 unused locals, E722 bare `except`, RUF012 ClassVar annotations for mutable class defaults, RUF013 explicit `Optional[...]`, and RUF005 iterable unpacking. With pylint and mypy gone from CI, this also strips all `# pylint: disable/enable` and `# type: ignore` directives from Python sources (PEP 484 `# type: <expr>` comments and `# fmt: off/on` are preserved), and runs the resulting files through ruff-format.
MasterJH5574
added a commit
to MasterJH5574/mlc-llm
that referenced
this pull request
Apr 20, 2026
Mirror the TVM setup (apache/tvm#18809): a minimal GHA workflow that runs `uv sync --group lint` plus `pre-commit/action`. Pre-commit is rewritten around ruff (check + format), replacing the previous isort/black/mypy/pylint/cmake-format stack, and gains yamllint, taplo, check-yaml, and check-toml. The corresponding Jenkins Lint stage, the ci/task/{isort,black,mypy,pylint,clang-format}.sh scripts, and .pylintrc are removed. pyproject.toml grows a [tool.ruff] section (select E/F/I/UP/RUF, line-length 100, py39 target) and a [dependency-groups] lint entry; the stale isort/black/mypy/pylint tool tables are dropped. To get the codebase green under the new ruler, existing UP006/UP035/ UP045/E501/RUF001/RUF002/E402/F821 violations are grandfathered via inline `# noqa`, so new code in those forms is still flagged. Real issues surfaced by the new rules are fixed directly: E741 renames (ambiguous `l`/`O`), F841 unused locals, E722 bare `except`, RUF012 ClassVar annotations for mutable class defaults, RUF013 explicit `Optional[...]`, and RUF005 iterable unpacking. With pylint and mypy gone from CI, this also strips all `# pylint: disable/enable` and `# type: ignore` directives from Python sources (PEP 484 `# type: <expr>` comments and `# fmt: off/on` are preserved), and runs the resulting files through ruff-format.
MasterJH5574
added a commit
to MasterJH5574/mlc-llm
that referenced
this pull request
Apr 20, 2026
Mirror the TVM setup (apache/tvm#18809): a minimal GHA workflow that runs `uv sync --group lint` plus `pre-commit/action`. Pre-commit is rewritten around ruff (check + format), replacing the previous isort/black/mypy/pylint/cmake-format stack, and gains yamllint, taplo, check-yaml, and check-toml. The corresponding Jenkins Lint stage, the ci/task/{isort,black,mypy,pylint,clang-format}.sh scripts, and .pylintrc are removed. pyproject.toml grows a [tool.ruff] section (select E/F/I/UP/RUF, line-length 100, py39 target) and a [dependency-groups] lint entry; the stale isort/black/mypy/pylint tool tables are dropped. To get the codebase green under the new ruler, existing UP006/UP035/ UP045/E501/RUF001/RUF002/E402/F821 violations are grandfathered via inline `# noqa`, so new code in those forms is still flagged. Real issues surfaced by the new rules are fixed directly: E741 renames (ambiguous `l`/`O`), F841 unused locals, E722 bare `except`, RUF012 ClassVar annotations for mutable class defaults, RUF013 explicit `Optional[...]`, and RUF005 iterable unpacking. With pylint and mypy gone from CI, this also strips all `# pylint: disable/enable` and `# type: ignore` directives from Python sources (PEP 484 `# type: <expr>` comments and `# fmt: off/on` are preserved), and runs the resulting files through ruff-format.
MasterJH5574
added a commit
to MasterJH5574/mlc-llm
that referenced
this pull request
Apr 20, 2026
Mirror the TVM setup (apache/tvm#18809): a minimal GHA workflow that runs `uv sync --group lint` plus `pre-commit/action`. Pre-commit is rewritten around ruff (check + format), replacing the previous isort/black/mypy/pylint/cmake-format stack, and gains yamllint, taplo, check-yaml, and check-toml. The corresponding Jenkins Lint stage, the ci/task/{isort,black,mypy,pylint,clang-format}.sh scripts, and .pylintrc are removed. pyproject.toml grows a [tool.ruff] section (select E/F/I/UP/RUF, line-length 100, py39 target) and a [dependency-groups] lint entry; the stale isort/black/mypy/pylint tool tables are dropped. To get the codebase green under the new ruler, existing UP006/UP035/ UP045/E501/RUF001/RUF002/E402/F821 violations are grandfathered via inline `# noqa`, so new code in those forms is still flagged. Real issues surfaced by the new rules are fixed directly: E741 renames (ambiguous `l`/`O`), F841 unused locals, E722 bare `except`, RUF012 ClassVar annotations for mutable class defaults, RUF013 explicit `Optional[...]`, and RUF005 iterable unpacking. With pylint and mypy gone from CI, this also strips all `# pylint: disable/enable` and `# type: ignore` directives from Python sources (PEP 484 `# type: <expr>` comments and `# fmt: off/on` are preserved), and runs the resulting files through ruff-format.
MasterJH5574
added a commit
to MasterJH5574/mlc-llm
that referenced
this pull request
Apr 20, 2026
Mirror the TVM setup (apache/tvm#18809): a minimal GHA workflow that runs `uv sync --group lint` plus `pre-commit/action`. Pre-commit is rewritten around ruff (check + format), replacing the previous isort/black/mypy/pylint/cmake-format stack, and gains yamllint, taplo, check-yaml, and check-toml. The corresponding Jenkins Lint stage, the ci/task/{isort,black,mypy,pylint,clang-format}.sh scripts, and .pylintrc are removed. pyproject.toml grows a [tool.ruff] section (select E/F/I/UP/RUF, line-length 100, py39 target) and a [dependency-groups] lint entry; the stale isort/black/mypy/pylint tool tables are dropped. To get the codebase green under the new ruler, existing UP006/UP035/ UP045/E501/RUF001/RUF002/E402/F821 violations are grandfathered via inline `# noqa`, so new code in those forms is still flagged. Real issues surfaced by the new rules are fixed directly: E741 renames (ambiguous `l`/`O`), F841 unused locals, E722 bare `except`, RUF012 ClassVar annotations for mutable class defaults, RUF013 explicit `Optional[...]`, and RUF005 iterable unpacking. With pylint and mypy gone from CI, this also strips all `# pylint: disable/enable` and `# type: ignore` directives from Python sources (PEP 484 `# type: <expr>` comments and `# fmt: off/on` are preserved), and runs the resulting files through ruff-format.
MasterJH5574
added a commit
to MasterJH5574/mlc-llm
that referenced
this pull request
Apr 20, 2026
Mirror the TVM setup (apache/tvm#18809): a minimal GHA workflow that runs `uv sync --group lint` plus `pre-commit/action`. Pre-commit is rewritten around ruff (check + format), replacing the previous isort/black/mypy/pylint/cmake-format stack, and gains yamllint, taplo, check-yaml, and check-toml. The corresponding Jenkins Lint stage, the ci/task/{isort,black,mypy,pylint,clang-format}.sh scripts, and .pylintrc are removed. pyproject.toml grows a [tool.ruff] section (select E/F/I/UP/RUF, line-length 100, py39 target) and a [dependency-groups] lint entry; the stale isort/black/mypy/pylint tool tables are dropped. To get the codebase green under the new ruler, existing UP006/UP035/ UP045/E501/RUF001/RUF002/E402/F821 violations are grandfathered via inline `# noqa`, so new code in those forms is still flagged. Real issues surfaced by the new rules are fixed directly: E741 renames (ambiguous `l`/`O`), F841 unused locals, E722 bare `except`, RUF012 ClassVar annotations for mutable class defaults, RUF013 explicit `Optional[...]`, and RUF005 iterable unpacking. With pylint and mypy gone from CI, this also strips all `# pylint: disable/enable` and `# type: ignore` directives from Python sources (PEP 484 `# type: <expr>` comments and `# fmt: off/on` are preserved), and runs the resulting files through ruff-format.
MasterJH5574
added a commit
to MasterJH5574/mlc-llm
that referenced
this pull request
Apr 20, 2026
Mirror the TVM setup (apache/tvm#18809): a minimal GHA workflow that runs `uv sync --group lint` plus `pre-commit/action`. Pre-commit is rewritten around ruff (check + format), replacing the previous isort/black/mypy/pylint/cmake-format stack, and gains yamllint, taplo, check-yaml, and check-toml. The corresponding Jenkins Lint stage, the ci/task/{isort,black,mypy,pylint,clang-format}.sh scripts, and .pylintrc are removed. pyproject.toml grows a [tool.ruff] section (select E/F/I/UP/RUF, line-length 100, py39 target) and a [dependency-groups] lint entry; the stale isort/black/mypy/pylint tool tables are dropped. To get the codebase green under the new ruler, existing UP006/UP035/ UP045/E501/RUF001/RUF002/E402/F821 violations are grandfathered via inline `# noqa`, so new code in those forms is still flagged. Real issues surfaced by the new rules are fixed directly: E741 renames (ambiguous `l`/`O`), F841 unused locals, E722 bare `except`, RUF012 ClassVar annotations for mutable class defaults, RUF013 explicit `Optional[...]`, and RUF005 iterable unpacking. With pylint and mypy gone from CI, this also strips all `# pylint: disable/enable` and `# type: ignore` directives from Python sources (PEP 484 `# type: <expr>` comments and `# fmt: off/on` are preserved), and runs the resulting files through ruff-format.
MasterJH5574
added a commit
to MasterJH5574/mlc-llm
that referenced
this pull request
Apr 20, 2026
Mirror the TVM setup (apache/tvm#18809): a minimal GHA workflow that runs `uv sync --group lint` plus `pre-commit/action`. Pre-commit is rewritten around ruff (check + format), replacing the previous isort/black/mypy/pylint/cmake-format stack, and gains yamllint, taplo, check-yaml, and check-toml. The corresponding Jenkins Lint stage, the ci/task/{isort,black,mypy,pylint,clang-format}.sh scripts, and .pylintrc are removed. pyproject.toml grows a [tool.ruff] section (select E/F/I/UP/RUF, line-length 100, py39 target) and a [dependency-groups] lint entry; the stale isort/black/mypy/pylint tool tables are dropped. To get the codebase green under the new ruler, existing UP006/UP035/ UP045/E501/RUF001/RUF002/E402/F821 violations are grandfathered via inline `# noqa`, so new code in those forms is still flagged. Real issues surfaced by the new rules are fixed directly: E741 renames (ambiguous `l`/`O`), F841 unused locals, E722 bare `except`, RUF012 ClassVar annotations for mutable class defaults, RUF013 explicit `Optional[...]`, and RUF005 iterable unpacking. With pylint and mypy gone from CI, this also strips all `# pylint: disable/enable` and `# type: ignore` directives from Python sources (PEP 484 `# type: <expr>` comments and `# fmt: off/on` are preserved), and runs the resulting files through ruff-format.
tlopex
pushed a commit
to mlc-ai/mlc-llm
that referenced
this pull request
Apr 22, 2026
Mirror the TVM setup (apache/tvm#18809): a minimal GHA workflow that runs `uv sync --group lint` plus `pre-commit/action`. Pre-commit is rewritten around ruff (check + format), replacing the previous isort/black/mypy/pylint/cmake-format stack, and gains yamllint, taplo, check-yaml, and check-toml. The corresponding Jenkins Lint stage, the ci/task/{isort,black,mypy,pylint,clang-format}.sh scripts, and .pylintrc are removed. pyproject.toml grows a [tool.ruff] section (select E/F/I/UP/RUF, line-length 100, py39 target) and a [dependency-groups] lint entry; the stale isort/black/mypy/pylint tool tables are dropped. To get the codebase green under the new ruler, existing UP006/UP035/ UP045/E501/RUF001/RUF002/E402/F821 violations are grandfathered via inline `# noqa`, so new code in those forms is still flagged. Real issues surfaced by the new rules are fixed directly: E741 renames (ambiguous `l`/`O`), F841 unused locals, E722 bare `except`, RUF012 ClassVar annotations for mutable class defaults, RUF013 explicit `Optional[...]`, and RUF005 iterable unpacking. With pylint and mypy gone from CI, this also strips all `# pylint: disable/enable` and `# type: ignore` directives from Python sources (PEP 484 `# type: <expr>` comments and `# fmt: off/on` are preserved), and runs the resulting files through ruff-format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub Actions workflow that runs pre-commit hooks and removes the need on jenkins to do lint