[REFACTOR][TEST] Remove unused te imports from test files#18804
Conversation
Remove unused `from tvm import te` imports from 24 test files across tir-transform, s_tir/transform, arith, testing, codegen and all-platform-minimal-test directories. Also replace the sole `te.var()` usage in test_s_tir_transform_decorate_device_scope.py with `tvm.tir.Var()`, and clean up stale `tvm.tir.ir_builder` references in test_tir_transform_convert_ssa.py comments.
Summary of ChangesHello @tqchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request continues the effort to migrate away from the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a refactoring that removes unused from tvm import te imports from 25 test files, as part of the ongoing migration from Tensor Expressions (TE) to TVMScript. The changes primarily involve deleting unused import statements. Additionally, a call to te.var has been correctly replaced with its tvm.tir.Var equivalent, and a stale comment has been updated. The changes are straightforward, correct, and contribute to improving the codebase's cleanliness. I have reviewed the pull request and found no issues.
This PR removes unused
from tvm import teimports from 25 test files across the codebase, continuing the ongoing TE → TVMScript migration cleanup.Changes:
from tvm import tefrom 24 test files in tir-transform/, s_tir/transform/, codegen/, arith/, all-platform-minimal-test/, and testing/te.var("x")withtvm.tir.Var("x", "int32")intest_s_tir_transform_decorate_device_scope.py(the only file where te was actually used)tvm.tir.ir_buildercomment references intest_tir_transform_convert_ssa.py