[REFACTOR] Migrate CHECK macros to tvm-ffi ones#18803
Merged
Merged
Conversation
tqchen
force-pushed
the
logging
branch
2 times, most recently
from
be60d85 to
c5bcda1
Compare
Contributor
Summary of ChangesHello @tqchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically refactors the error handling mechanisms across the codebase. By migrating to Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a large-scale refactoring that migrates various check macros (ICHECK, CHECK, LOG(FATAL)) to their tvm-ffi counterparts (TVM_FFI_ICHECK, TVM_FFI_THROW, etc.). This is an excellent change that unifies and simplifies error handling across the codebase. The migration has been done consistently and correctly across numerous files. I particularly appreciate the move towards more specific, typed exceptions (e.g., ValueError, IndexError, TypeError) where appropriate, which improves error diagnostics. The refactoring of include/tvm/runtime/logging.h is also a significant cleanup. Overall, this is a high-quality contribution that enhances code maintainability and robustness. Great work!
tqchen
force-pushed
the
logging
branch
4 times, most recently
from
1774636 to
da1f119
Compare
This PR migrates the check macros to tvm ffi ones to simplify and unify the error handling.
guan404ming
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the check macros to tvm ffi ones
to simplify and unify the error handling.