Skip to content

[FFI] Bring up latest tvm-ffi#18802

Merged
tqchen merged 2 commits into
apache:mainfrom
tqchen:tvm-ffi-bringup
Feb 20, 2026
Merged

[FFI] Bring up latest tvm-ffi#18802
tqchen merged 2 commits into
apache:mainfrom
tqchen:tvm-ffi-bringup

Conversation

@tqchen

@tqchen tqchen commented Feb 20, 2026

Copy link
Copy Markdown
Member

This PR brings up tvm-ffi dependency to latest

This PR brings up support for latest tvm ffi
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @tqchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the tvm-ffi subproject to its most recent version, ensuring the project leverages the latest foreign function interface capabilities. Concurrently, it introduces a significant enhancement to the ConfigSchema by enabling default configuration values to be dynamically generated by factory functions, thereby increasing flexibility and expressiveness in defining configuration schemas.

Highlights

  • tvm-ffi Subproject Update: The tvm-ffi subproject has been updated to its latest commit, bringing in recent FFI improvements.
  • ConfigSchema Enhancements: The ConfigSchema mechanism now supports providing default values through factory functions, offering more dynamic configuration options.
  • Refactored Default Value Handling: Internal logic within ConfigSchema has been refactored to properly distinguish and handle default values that are static versus those generated by factory functions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • 3rdparty/tvm-ffi
    • Updated the tvm-ffi subproject commit from c78e8b4eefa076c457af97bd3930dd664aec71c3 to 35cbc3272cf4b02d8d2e34d2510be5b34d0046ea.
  • include/tvm/ir/config_schema.h
    • Added a default_from_factory boolean member to ConfigSchema::Entry to indicate if a default value is produced by a factory function.
    • Modified the ConfigSchema::Apply method to conditionally invoke a factory function for default values if default_from_factory is true.
    • Updated the ConfigSchema::Apply trait processing to correctly handle and assign the default_from_factory flag and the default_value_or_factory.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the tvm-ffi submodule to a more recent commit. The changes in include/tvm/ir/config_schema.h are a direct result of this update, adapting the code to support default value factories for configuration options. The modifications to the OptionEntry struct and the Resolve and MakeEntry methods are consistent with the new functionality provided by the updated dependency. The implementation appears correct and the changes are well-contained.

@tqchen tqchen merged commit d8a4e6d into apache:main Feb 20, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants