Skip to content

[DOC] Fix docstring, unify CMake, nvidia-docker deprecation#18799

Merged
tlopex merged 3 commits into
apache:mainfrom
ruslo:pr.doc
Feb 19, 2026
Merged

[DOC] Fix docstring, unify CMake, nvidia-docker deprecation#18799
tlopex merged 3 commits into
apache:mainfrom
ruslo:pr.doc

Conversation

@ruslo

@ruslo ruslo commented Feb 19, 2026

Copy link
Copy Markdown
Contributor
  • Fix docstring in transform.py
  • Unify CMake naming
  • nvidia-docker is deprecated

Fix CMake naming in documentation, comments and scripts

- Cmake -> CMake
- cmake -> CMake
nvidia-docker is deprecated and the NVIDIA Container Toolkit should be used instead
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ruslo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving code quality and documentation. It addresses inconsistencies in CMake naming, updates outdated references to nvidia-docker, and fixes a docstring in transform.py. These changes enhance the overall maintainability and clarity of the codebase.

Highlights

  • Docstring Fix: Corrected a docstring in transform.py for better clarity.
  • CMake Naming Unification: Standardized CMake naming conventions across multiple files for consistency.
  • Nvidia-Docker Deprecation: Replaced references to the deprecated nvidia-docker with NVIDIA Container Toolkit in the documentation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • CMakeLists.txt
    • Corrected a comment regarding CMake behavior changes related to static linking.
    • Updated comments to refer to 'CMake' instead of 'cmake'.
  • Makefile
    • Updated comments to refer to 'CMake' instead of 'cmake'.
  • apps/cpp_rpc/CMakeLists.txt
    • Updated comment to refer to 'CMake' instead of 'cmake'.
  • apps/cpp_rpc/README.md
    • Replaced 'cmake' with 'CMake' in the documentation.
  • apps/hexagon_api/README.md
    • Replaced 'cmake' with 'CMake' in the documentation.
  • apps/hexagon_launcher/README.md
    • Replaced 'cmake' with 'CMake' in the documentation.
  • apps/hexagon_launcher/cmake/HexagonLauncher.cmake
    • Replaced 'cmake' with 'CMake' in a comment.
  • apps/ios_rpc/CMakeLists.txt
    • Replaced 'Cmake' with 'CMake' in a comment.
  • apps/ios_rpc/README.md
    • Replaced 'cmake' with 'CMake' in the documentation.
  • ci/jenkins/generated/arm_jenkinsfile.groovy
    • Replaced 'cmake' with 'CMake' in label descriptions.
  • ci/jenkins/generated/cpu_jenkinsfile.groovy
    • Replaced 'cmake' with 'CMake' in label descriptions.
  • ci/jenkins/generated/docker_jenkinsfile.groovy
    • Replaced 'cmake' with 'CMake' in label descriptions.
  • ci/jenkins/generated/gpu_jenkinsfile.groovy
    • Replaced 'cmake' with 'CMake' in label descriptions.
  • ci/jenkins/generated/lint_jenkinsfile.groovy
    • Replaced 'cmake' with 'CMake' in label descriptions.
  • ci/jenkins/generated/wasm_jenkinsfile.groovy
    • Replaced 'cmake' with 'CMake' in label descriptions.
  • ci/jenkins/templates/arm_jenkinsfile.groovy.j2
    • Replaced 'cmake' with 'CMake' in label descriptions.
  • ci/jenkins/templates/cpu_jenkinsfile.groovy.j2
    • Replaced 'cmake' with 'CMake' in label descriptions.
  • ci/jenkins/templates/utils/Build.groovy.j2
    • Replaced 'cmake' with 'CMake' in label descriptions.
  • ci/jenkins/templates/wasm_jenkinsfile.groovy.j2
    • Replaced 'cmake' with 'CMake' in label descriptions.
  • cmake/config.cmake
    • Replaced 'cmake' with 'CMake' in comments and descriptions throughout the file.
  • cmake/libs/Libbacktrace.cmake
    • Replaced 'cmake' with 'CMake' in a comment.
  • cmake/modules/CUDA.cmake
    • Replaced 'cmake' with 'CMake' in comments and a fatal error message.
    • Addressed an issue with NVCC include directives and compile_commands.json generation in newer CMake versions.
  • cmake/modules/ClangFlags.cmake
    • Replaced 'cmake' with 'CMake' in a comment.
  • cmake/modules/ROCM.cmake
    • Replaced 'cmake' with 'CMake' in a comment.
  • cmake/modules/contrib/ArmComputeLib.cmake
    • Replaced 'Cmake' with 'CMake' in a comment.
  • cmake/modules/contrib/CLML.cmake
    • Replaced 'Cmake' with 'CMake' in a comment.
  • cmake/utils/Utils.cmake
    • Replaced 'cmake' with 'CMake' in comments.
  • docker/bash.sh
    • Replaced 'cmake' with 'CMake' in a comment.
  • docker/install/ubuntu_install_python.sh
    • Replaced 'cmake' with 'CMake' in a comment.
  • docs/install/docker.rst
    • Replaced nvidia-docker with NVIDIA Container Toolkit in the documentation, as nvidia-docker is deprecated.
  • docs/install/from_source.rst
    • Replaced 'cmake' with 'CMake' in the documentation.
  • python/tvm/libinfo.py
    • Replaced 'cmake' with 'CMake' in a comment.
  • python/tvm/relax/transform/transform.py
    • Added a newline in the MetaScheduleTuneTIR docstring for better formatting.
  • src/contrib/msc/plugin/base_codegen.h
    • Replaced 'cmake' with 'CMake' in comments.
  • src/contrib/msc/plugin/tensorrt_codegen.h
    • Replaced 'cmake' with 'CMake' in a comment.
  • src/contrib/msc/plugin/torch_codegen.h
    • Replaced 'cmake' with 'CMake' in a comment.
  • src/contrib/msc/plugin/tvm_codegen.h
    • Replaced 'cmake' with 'CMake' in a comment.
  • src/runtime/hexagon/README.md
    • Replaced 'cmake' with 'CMake' in the documentation.
  • src/support/libinfo.cc
    • Replaced 'cmake' with 'CMake' in a comment.
  • src/target/datatype/posit/posit-wrapper.cc
    • Replaced 'cmake' with 'CMake' in a comment.
Activity
  • The pull request author, ruslo, has addressed minor documentation and naming inconsistencies.
  • The changes primarily involve replacing 'cmake' with 'CMake' to align with standard naming conventions.
  • The documentation has been updated to reflect the deprecation of nvidia-docker, recommending the use of NVIDIA Container Toolkit instead.
  • A docstring in transform.py was corrected for improved clarity.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily focuses on documentation and comment cleanup to improve consistency and accuracy across the project. Key changes include unifying the capitalization of 'CMake' in build scripts, comments, and display labels, updating documentation to reflect the deprecation of nvidia-docker in favor of the NVIDIA Container Toolkit, and fixing a docstring formatting issue in transform.py. These changes enhance the maintainability and clarity of the project's documentation and infrastructure. No issues of medium or higher severity were identified during the review, as the modifications are stylistic or informational and do not impact the functional logic of the codebase.

@ruslo ruslo mentioned this pull request Feb 19, 2026
@tlopex tlopex merged commit 1ebd5e0 into apache:main Feb 19, 2026
7 checks passed
@ruslo ruslo deleted the pr.doc branch February 23, 2026 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants