[CONTRIB] Cache the shape and dtype array in json access

[tqchen]

This PR caches the shape dtype array in json access to improve overall efficiency.

[gemini-code-assist]

Summary of Changes

Hello @tqchen, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes the JSONGraphNode class by implementing a caching mechanism for shape and data type information. By storing these frequently accessed properties directly as member variables, the system reduces redundant attribute parsing, thereby improving the overall performance and efficiency of JSON graph operations.

Highlights

• Performance Improvement: Introduced caching for shape and dtype arrays within the JSONGraphNode class to enhance efficiency during JSON graph access.
• Class Structure Update: Added new member variables shape_ (for ffi::Array<ffi::Array<int64_t>>) and dtype_ (for ffi::Array<DLDataType>) to JSONGraphNode to store cached values.
• Constructor Modification: Updated the JSONGraphNode constructor to populate the newly introduced shape_ and dtype_ member variables from existing attributes upon object creation.
• Accessor Optimization: Modified GetOpShape() and GetOpDataType() methods to directly return the cached shape_ and dtype_ values, eliminating the need for repeated attribute lookups.
• Setter Integration: Adjusted SetShape() and SetDType() methods to not only set the attributes but also update the corresponding cached shape_ and dtype_ member variables.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/runtime/contrib/json/json_node.h
  • Added shape_ and dtype_ member variables to JSONGraphNode for caching.
  • Modified the JSONGraphNode constructor to initialize shape_ and dtype_ from existing attributes.
  • Updated GetOpShape() and GetOpDataType() to return the cached shape_ and dtype_ respectively.
  • Adjusted SetShape() and SetDType() to also update the new cached member variables.

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces caching for shape and dtype arrays in JSON access, aiming to improve efficiency. The changes involve adding shape_ and dtype_ members to the JSONGraphNode class, populating them during attribute loading, and modifying GetOpShape and GetOpDataType to return these cached values. Additionally, SetShape and SetDType methods are updated to also set the cached members. The changes are well-contained and directly address the stated objective.