support integer types in fast_tanh and fast_exp

[jikechao]

Fix #18767.

This PR fixes the issue by adding explicit type casting in fast_tanh and fast_exp to convert integer inputs to float32.

[gemini-code-assist]

Summary of Changes

Hello @jikechao, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the fast_tanh function by introducing a mechanism to automatically convert integer input tensors to float32. This change addresses a reported bug where the function failed to process integer types correctly, thereby broadening its compatibility and ensuring reliable operation across various numerical inputs without requiring manual type conversion from the user.

Highlights

• Integer Type Support: Added explicit type casting within the fast_tanh function to convert integer (int and uint) input tensors to float32.
• Bug Fix: Resolved an issue where fast_tanh did not correctly handle integer input types, preventing potential errors and improving function robustness.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• python/tvm/topi/math.py
  • Added explicit type casting for integer and unsigned integer inputs to float32 in the fast_tanh function.

Activity

• No specific activity (comments, reviews, progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request correctly adds support for integer types in fast_tanh by casting them to float32, which aligns with the behavior of other mathematical functions in the library. The implementation is sound. I have a minor suggestion to improve the conciseness of the code.

[gemini-code-assist]

This condition can be made more concise. The startswith method can accept a tuple of strings to check for multiple prefixes.

Suggested change

	if x.dtype.startswith('int') or x.dtype.startswith('uint'):
	if x.dtype.startswith(('int', 'uint')):

[tlopex]

Could you fix the lint issue?

[jikechao]

Could you fix the lint issue?

I have fixed it. Could you help me review it again? Thanks a lot!

[tlopex]

LGTM Thanks！