Skip to content

[chore] Cleanup stale dependencies#18760

Merged
tqchen merged 1 commit into
apache:mainfrom
tqchen:ci-cleanup
Feb 12, 2026
Merged

[chore] Cleanup stale dependencies#18760
tqchen merged 1 commit into
apache:mainfrom
tqchen:ci-cleanup

Conversation

@tqchen

@tqchen tqchen commented Feb 12, 2026

Copy link
Copy Markdown
Member

This PR cleansup stale thirdparty dependencies that are no longer needed.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @tqchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on streamlining the project by removing several third-party dependencies that are no longer required. This cleanup reduces the project's overall footprint, simplifies its build configuration, and updates license attributions to accurately reflect the current set of external components.

Highlights

  • Dependency Removal: Removed cnpy and zlib submodules from the project's Git configuration.
  • Library Elimination: Eliminated the entire libcrc third-party library, including its source files, headers, and associated build configurations.
  • MLPerf Tiny Removal: Removed the mlperftiny third-party library, including its API files and documentation.
  • License Updates: Updated the main LICENSE file and removed individual license files to reflect the deletion of these dependencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .gitmodules
    • Removed cnpy submodule entry.
    • Removed zlib submodule entry.
  • 3rdparty/cnpy
    • Removed the cnpy subproject directory.
  • 3rdparty/libcrc/.gitignore
    • Removed the .gitignore file for the libcrc library.
  • 3rdparty/libcrc/include/checksum.h
    • Removed the checksum.h header file from the libcrc library.
  • 3rdparty/libcrc/src/crcccitt.c
    • Removed the crcccitt.c source file from the libcrc library.
  • 3rdparty/libcrc/tab/gentab_ccitt.inc
    • Removed the gentab_ccitt.inc file from the libcrc library.
  • 3rdparty/mlperftiny/README.md
    • Removed the README.md file for the mlperftiny library.
  • 3rdparty/mlperftiny/api/internally_implemented.cpp
    • Removed the internally_implemented.cpp file for the mlperftiny library.
  • 3rdparty/mlperftiny/api/internally_implemented.h
    • Removed the internally_implemented.h file for the mlperftiny library.
  • 3rdparty/mlperftiny/api/submitter_implemented.h
    • Removed the submitter_implemented.h file for the mlperftiny library.
  • 3rdparty/zlib
    • Removed the zlib subproject directory.
  • CMakeLists.txt
    • Removed CRC16_INCLUDE_PATH variable definition.
    • Removed target_include_directories calls referencing CRC16_INCLUDE_PATH.
  • LICENSE
    • Removed dlpack, mlperftiny, libcrc, cma, cnpy, zlib, and libbacktrace from license attribution lists.
  • licenses/LICENSE.cma.txt
    • Removed the cma license file.
  • licenses/LICENSE.cnpy.txt
    • Removed the cnpy license file.
  • licenses/LICENSE.libcrc.txt
    • Removed the libcrc license file.
  • licenses/LICENSE.zlib.txt
    • Removed the zlib license file.
Activity
  • No specific activity (comments, reviews, progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request does a good job of cleaning up several stale third-party dependencies, which is a good maintenance task. The changes mostly involve removing files and updating build configurations and license files. The removals of cnpy, zlib, libcrc, and mlperftiny seem correct and are consistently applied. However, I've found a couple of potentially incorrect removals from the main LICENSE file for dependencies that appear to still be in use. These could lead to license compliance issues and should be addressed.

Comment thread LICENSE
Comment thread LICENSE
@tqchen tqchen force-pushed the ci-cleanup branch 2 times, most recently from e9566b5 to 8c992af Compare February 12, 2026 00:40
This PR cleansup stale thirdparty dependencies
and options that are no longer needed.
@tqchen tqchen merged commit 6901832 into apache:main Feb 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants