[chore] Cleanup stale dependencies#18760
Conversation
Summary of ChangesHello @tqchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on streamlining the project by removing several third-party dependencies that are no longer required. This cleanup reduces the project's overall footprint, simplifies its build configuration, and updates license attributions to accurately reflect the current set of external components. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request does a good job of cleaning up several stale third-party dependencies, which is a good maintenance task. The changes mostly involve removing files and updating build configurations and license files. The removals of cnpy, zlib, libcrc, and mlperftiny seem correct and are consistently applied. However, I've found a couple of potentially incorrect removals from the main LICENSE file for dependencies that appear to still be in use. These could lead to license compliance issues and should be addressed.
e9566b5 to
8c992af
Compare
This PR cleansup stale thirdparty dependencies and options that are no longer needed.
This PR cleansup stale thirdparty dependencies that are no longer needed.