[REFACTOR][S-TIR] Cleanup items on block scope

[tqchen]

This PR finishes cleans up items for sblock scope migration into s_tir namespace.

[gemini-code-assist]

Summary of Changes

Hello @tqchen, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request completes the migration of block scope related functionalities into the s_tir namespace. It involves the removal of an outdated Python file and the renaming and relocation of a core C++ file, contributing to a cleaner and more organized codebase for the s_tir module.

Highlights

• File Removal: Removed the block_dependence_info.py file, streamlining the Python s_tir module by eliminating an outdated component.
• File Renaming and Relocation: Renamed src/tir/ir/block_scope.cc to sblock_scope.cc and relocated it to src/s_tir, aligning its placement with the s_tir namespace migration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• python/tvm/s_tir/block_dependence_info.py
  • Removed the entire file.
• src/tir/ir/block_scope.cc
  • Renamed to sblock_scope.cc.
  • Moved to the src/s_tir directory.

Activity

• No specific activity (comments, reviews, etc.) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a refactoring that moves files related to sblock scope into the s_tir namespace as part of a cleanup effort. Specifically, python/tvm/s_tir/block_dependence_info.py is removed (and its contents appear to be moved to a new file), and src/tir/ir/block_scope.cc is renamed. The changes are primarily file operations. I've identified a couple of minor documentation inconsistencies in the Python code that was moved and provided suggestions to fix them. Overall, the refactoring is a good step towards better code organization.

I am having trouble creating individual review comments. Click here to see my feedback.

python/tvm/s_tir/block_dependence_info.py (63-64)

The parameter name in the docstring (stmt) does not match the function signature (block). Please update it for consistency. Using the specific type SBlock instead of the alias Block would also improve clarity.

        block : SBlock
            The block for which the sref is to be retrived

python/tvm/s_tir/block_dependence_info.py (83-84)

The return type in the docstring is StmtSRef, but the function's type hint and implementation return an SBlockScope. Please correct the docstring.

        scope : SBlockScope
            The corresponding SBlockScope