Skip to content

[DOC] Fix the loop length in a loop tiling example#18753

Merged
tlopex merged 1 commit into
apache:mainfrom
ruslo:pr.fix_loop_length
Feb 11, 2026
Merged

[DOC] Fix the loop length in a loop tiling example#18753
tlopex merged 1 commit into
apache:mainfrom
ruslo:pr.fix_loop_length

Conversation

@ruslo

@ruslo ruslo commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

According to the code, the loop is split by 16x8, not by 32x4

According to the code, the loop is split by 16x8, not by 32x4
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ruslo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an inaccuracy in the tir_transformation.py tutorial documentation. It updates the textual descriptions of loop lengths and ranges to correctly align with the actual 16x8 loop tiling split performed in the example, ensuring the documentation accurately reflects the code's behavior.

Highlights

  • Documentation Correction: Corrected the described loop length for the inner loop j from 4 to 8 in the tir_transformation.py tutorial documentation.
  • Loop Range Update: Updated the described ranges for the split loops j_0 and j_1 from 32 and 4 to 16 and 8, respectively, to accurately reflect the 16x8 split.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • docs/deep_dive/tensor_ir/tutorials/tir_transformation.py
    • Updated the comment describing the inner loop length from 4 to 8.
    • Corrected the comment describing the ranges of the split loops j_0 and j_1 from 32 and 4 to 16 and 8.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a documentation fix for the TensorIR transformation tutorial. The changes update comments to accurately reflect the loop tiling factors used in the example code. The comments previously stated a loop split of 32x4, but the code actually performs a 16x8 split. This PR corrects the comments to match the code, improving the clarity and accuracy of the tutorial for users. The changes are correct and well-justified.

@tlopex tlopex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction!

@tlopex tlopex merged commit 4578a61 into apache:main Feb 11, 2026
10 checks passed
@ruslo ruslo deleted the pr.fix_loop_length branch February 12, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants