fix: correct typos 'recieve' and 'occurence'#18739
Conversation
Summary of ChangesHello @thecaptain789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the textual accuracy of the codebase by rectifying common spelling errors found in docstrings. These minor corrections contribute to improved readability and maintain the professional quality of the project's internal documentation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly fixes two typos. I've added one suggestion to fix another typo in the same area.
Additionally, while reviewing, I noticed a few other typos in the codebase that you might want to address in a follow-up PR, since they are outside the changed files:
- In
python/tvm/ir/base.py:- line 191:
assert_strucural_equalshould beassert_structural_equal. - line 292:
structrual_equalshould bestructural_equal.
- line 191:
- In
include/tvm/node/structural_hash.h:- line 20: The comment says
structural_equal.hbut the filename isstructural_hash.h.
- line 20: The comment says
- In
tests/python/tir-base/test_tir_structural_equal_hash.py:- The word
sequalis used multiple times (e.g., inget_sequal_mismatch). This appears to be a typo fors_equalorstructural_equal.
- The word
| first occurrence during the visit. The hash value of a graph node is | ||
| combined from the hash values of its contents and the index. | ||
|
|
||
| structural_hash is made to be concistent with structural_equal. |
There was a problem hiding this comment.
Since you're fixing a typo in this docstring, you could also fix another one on line 266: concistent should be consistent.
| first occurrence during the visit. The hash value of a graph node is | |
| combined from the hash values of its contents and the index. | |
| structural_hash is made to be concistent with structural_equal. | |
| first occurrence during the visit. The hash value of a graph node is | |
| combined from the hash values of its contents and the index. | |
| structural_hash is made to be consistent with structural_equal. |
|
@tvm-bot rerun |
1 similar comment
|
@tvm-bot rerun |
Fix typos in docstrings and comments identified by Gemini Code Assist during PR apache#18739 review: - python/tvm/ir/base.py: 'assert_strucural_equal' → 'assert_structural_equal' - python/tvm/ir/base.py: 'structrual_equal' → 'structural_equal' - include/tvm/node/structural_hash.h: fix file path in comment - tests/python/tir-base/test_tir_structural_equal_hash.py: 'sequal' → 'struct_equal' for consistency with variable names
cchung100m
left a comment
There was a problem hiding this comment.
LGTM, thanks to @thecaptain789 😄
Fixed typos in Python code: 'recieve' to 'receive' and 'occurence' to 'occurrence'.