Skip to content

fix: correct typos 'recieve' and 'occurence'#18739

Merged
tlopex merged 1 commit into
apache:mainfrom
thecaptain789:fix-typos-recieve-occurence
Feb 10, 2026
Merged

fix: correct typos 'recieve' and 'occurence'#18739
tlopex merged 1 commit into
apache:mainfrom
thecaptain789:fix-typos-recieve-occurence

Conversation

@thecaptain789

Copy link
Copy Markdown
Contributor

Fixed typos in Python code: 'recieve' to 'receive' and 'occurence' to 'occurrence'.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @thecaptain789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the textual accuracy of the codebase by rectifying common spelling errors found in docstrings. These minor corrections contribute to improved readability and maintain the professional quality of the project's internal documentation.

Highlights

  • Typo Correction: 'occurence': The spelling of 'occurence' has been corrected to 'occurrence' in the docstring for the structural_hash function within python/tvm/ir/base.py.
  • Typo Correction: 'recieve': The spelling of 'recieve' has been corrected to 'receive' in the docstring for the call_packed_lowered function within python/tvm/tir/op.py.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • python/tvm/ir/base.py
    • Corrected 'occurence' to 'occurrence' in the docstring for structural_hash.
  • python/tvm/tir/op.py
    • Corrected 'recieve' to 'receive' in the docstring for call_packed_lowered.
Activity
  • No human activity has been recorded on this pull request since its creation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes two typos. I've added one suggestion to fix another typo in the same area.

Additionally, while reviewing, I noticed a few other typos in the codebase that you might want to address in a follow-up PR, since they are outside the changed files:

  • In python/tvm/ir/base.py:
    • line 191: assert_strucural_equal should be assert_structural_equal.
    • line 292: structrual_equal should be structural_equal.
  • In include/tvm/node/structural_hash.h:
    • line 20: The comment says structural_equal.h but the filename is structural_hash.h.
  • In tests/python/tir-base/test_tir_structural_equal_hash.py:
    • The word sequal is used multiple times (e.g., in get_sequal_mismatch). This appears to be a typo for s_equal or structural_equal.

Comment thread python/tvm/ir/base.py
Comment on lines +263 to 266
first occurrence during the visit. The hash value of a graph node is
combined from the hash values of its contents and the index.

structural_hash is made to be concistent with structural_equal.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since you're fixing a typo in this docstring, you could also fix another one on line 266: concistent should be consistent.

Suggested change
first occurrence during the visit. The hash value of a graph node is
combined from the hash values of its contents and the index.
structural_hash is made to be concistent with structural_equal.
first occurrence during the visit. The hash value of a graph node is
combined from the hash values of its contents and the index.
structural_hash is made to be consistent with structural_equal.

@tlopex

tlopex commented Feb 9, 2026

Copy link
Copy Markdown
Member

@tvm-bot rerun

1 similar comment
@tlopex

tlopex commented Feb 9, 2026

Copy link
Copy Markdown
Member

@tvm-bot rerun

thecaptain789 added a commit to thecaptain789/tvm that referenced this pull request Feb 9, 2026
Fix typos in docstrings and comments identified by Gemini Code Assist
during PR apache#18739 review:

- python/tvm/ir/base.py: 'assert_strucural_equal' → 'assert_structural_equal'
- python/tvm/ir/base.py: 'structrual_equal' → 'structural_equal'
- include/tvm/node/structural_hash.h: fix file path in comment
- tests/python/tir-base/test_tir_structural_equal_hash.py: 'sequal' → 'struct_equal' for consistency with variable names

@cchung100m cchung100m left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks to @thecaptain789 😄

@tlopex tlopex merged commit 90f2732 into apache:main Feb 10, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants