[REFACTOR][S-TIR] Migrate meta_schedule into s_tir namespace#18735
Merged
Conversation
Contributor
Summary of ChangesHello @tqchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant refactoring by moving the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request undertakes a significant refactoring to migrate the meta_schedule module into the s_tir namespace. The changes are extensive, involving file moves, namespace updates in C++ and Python code, and adjustments to build configurations. Overall, the migration appears to be thorough. I've identified a critical issue where an FFI function registration was accidentally removed, which would break Python bindings. I also have a concern about the scope of changes in CMakeLists.txt. Please see my detailed comments.
| return TuningRecord(trace, workload, run_secs, target, args_info); | ||
| }) | ||
| .def_method("meta_schedule.TuningRecordAsMeasureCandidate", | ||
| .def_method("s_tir.meta_schedule.TuningRecordAsMeasureCandidate", |
Contributor
There was a problem hiding this comment.
The FFI registration for TuningRecordAsMeasureCandidate seems to have been accidentally removed instead of being renamed. This will break the TuningRecord.as_measure_candidate() method in Python. Please add it back.
Suggested change
| .def_method("s_tir.meta_schedule.TuningRecordAsMeasureCandidate", | |
| .def_method("s_tir.meta_schedule.TuningRecordAsMeasureCandidate", &TuningRecordNode::AsMeasureCandidate) | |
| .def_method("s_tir.meta_schedule.TuningRecordAsJSON", &TuningRecordNode::AsJSON) |
|
|
||
| # Source file lists | ||
| tvm_file_glob(GLOB_RECURSE COMPILER_SRCS | ||
| src/auto_scheduler/*.cc |
Contributor
There was a problem hiding this comment.
The removal of src/auto_scheduler/*.cc (and src/autotvm/*.cc on line 299) seems out of scope for a PR that is migrating meta_schedule. If this is intended, it would be better to move this change to a separate PR with a more descriptive title to avoid confusion.
tlopex
approved these changes
Feb 8, 2026
This PR migrates meta_schedule into the s_tir namespace.
guan404ming
approved these changes
Feb 8, 2026
guan404ming
left a comment
guan404ming
left a comment
Member
There was a problem hiding this comment.
Thanks for the great work! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates meta_schedule into the s_tir namespace.