[REFACTOR][S-TIR] Initialize the s_tir module#18712
Conversation
Summary of ChangesHello @tqchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes the foundational Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a major refactoring by initializing the s_tir module for schedulable TensorIR, primarily by replacing tvm.tir.Schedule with tvm.s_tir.Schedule across the codebase. The changes are extensive, touching tests, documentation, and various parts of the dlight and meta_schedule components. Overall, the refactoring appears to be thorough and consistent. I've identified one issue in a test file that would cause a NameError due to a missing import qualification. Addressing this will ensure the tests pass and the refactoring is complete.
|
cc @Hzfengsy |
c0a58e6 to
43a2c26
Compare
This PR initalizes the s_tir for scheduable TensorIR. The change mainly starts from python side, the we will gradually move towards the c++ side in followup PRs. The python main change: tir.Schedule => s_tir.Schedule
This PR initalizes the s_tir for scheduable TensorIR. The change mainly starts from python side, the we will gradually move towards the c++ side in followup PRs. The python main change:
tir.Schedule => s_tir.Schedule