Skip to content

[Relax] Add mod operator support #18559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mshr-h merged 1 commit into from
Dec 9, 2025
Merged

[Relax] Add mod operator support #18559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions python/tvm/relax/expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,7 @@ def __rfloordiv__(self, other: Expr) -> "ExprWithOp":
return _binary_rhs_helper(other)

def __mod__(self, other: Expr) -> "ExprWithOp":
# TODO(siyuan): Support it after mod operator is supported in relax
raise ValueError("relax.mod is not supported yet.")
return _binary_op_helper(self, other, _op_ffi_api.mod) # type: ignore

def __rmod__(self, other: Expr) -> "ExprWithOp":
return _binary_rhs_helper(other)
Expand Down
4 changes: 4 additions & 0 deletions tests/python/relax/test_op_binary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ def test_op_correctness():
assert relax.op.multiply(x, y).op == Op.get("relax.multiply")
assert relax.op.power(x, y).op == Op.get("relax.power")
assert relax.op.subtract(x, y).op == Op.get("relax.subtract")
assert relax.op.mod(x, y).op == Op.get("relax.mod")
assert relax.op.floor_mod(x, y).op == Op.get("relax.floor_mod")

assert relax.op.equal(x, y).op == Op.get("relax.equal")
assert relax.op.greater(x, y).op == Op.get("relax.greater")
Expand Down Expand Up @@ -70,6 +72,8 @@ def _check_inference(bb: relax.BlockBuilder, call: relax.Call, expected_sinfo: r
(relax.op.subtract, tir.Sub),
(relax.op.maximum, tir.Max),
(relax.op.minimum, tir.Min),
(relax.op.mod, tir.Mod),
(relax.op.floor_mod, tir.FloorMod),
)


Expand Down
Loading