Skip to content

[Bugfix][Frontend][Keras] Add a check to reject the invalid input shape#15335

Merged
masahi merged 13 commits into
apache:mainfrom
jikechao:patch_check_shape
Jul 20, 2023
Merged

[Bugfix][Frontend][Keras] Add a check to reject the invalid input shape#15335
masahi merged 13 commits into
apache:mainfrom
jikechao:patch_check_shape

Conversation

@jikechao

Copy link
Copy Markdown
Member

This pr adds a checking for the input_shape. If the input_shape is invalid, we will reject it immediately!

@tvm-bot

tvm-bot commented Jul 17, 2023

Copy link
Copy Markdown
Collaborator

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: bugfix, frontend, keras See #10317 for details

Generated by tvm-bot

@leandron leandron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jikechao

@jikechao

Copy link
Copy Markdown
Member Author

@leandron Thanks for your review!

@jikechao

Copy link
Copy Markdown
Member Author

@tvm-bot rerun

@echuraev echuraev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jikechao

Copy link
Copy Markdown
Member Author

@Hzfengsy @echuraev @leandron
CI passed. Could you help me merge this PR?

@masahi masahi merged commit 03fecba into apache:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants