-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[Adreno] Adapt reduction schedule for adreno #13100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5320706
[Adreno] Adapt reduction schedule for adreno
elvin-n b3df7b1
Address PR comments
elvin-n 17588bb
Remove copy-paste, start reuse cuda impl
elvin-n f4f1a03
Address pylint hits
elvin-n 32f394d
Extend comment for cuda schedule_reduce_impl
elvin-n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| # pylint: disable=invalid-name,unused-variable,too-many-locals,len-as-condition | ||
| """Schedule for reduce operators""" | ||
| import numpy | ||
| from tvm import te | ||
| from ..utils import get_const_tuple | ||
| from .injective import schedule_injective_from_existing | ||
| from .utils import get_div | ||
| from ..cuda.reduction import schedule_reduce_impl | ||
|
|
||
|
|
||
| def _schedule_reduce_adreno(op, sch, is_idx_reduce=False): | ||
| if is_idx_reduce: | ||
| real_output = op.output(0) | ||
| temp_idx_input = op.input_tensors[0].op.output(0) | ||
| temp_val_input = op.input_tensors[0].op.output(1) | ||
| else: | ||
| real_output = op.output(0) | ||
| shape = get_const_tuple(real_output.shape) | ||
| latest4 = shape[-1] == 4 | ||
| div4 = numpy.prod(shape) % 4 == 0 | ||
|
|
||
| # Fuse and split the axis | ||
| if latest4: | ||
| fused_outer = sch[real_output].fuse( | ||
| *[sch[real_output].op.axis[i] for i in range(len(sch[real_output].op.axis) - 1)] | ||
| ) | ||
| else: | ||
| fused_outer = sch[real_output].fuse( | ||
| *[sch[real_output].op.axis[i] for i in range(len(sch[real_output].op.axis))] | ||
| ) | ||
|
|
||
| ftc = numpy.prod(shape) | ||
| a = fused_outer | ||
| if latest4: | ||
| sch[real_output].vectorize(sch[real_output].op.axis[-1]) | ||
| elif div4 and not is_idx_reduce: | ||
| a, b = sch[real_output].split(fused_outer, factor=4) | ||
| sch[real_output].vectorize(b) | ||
| ftc = ftc / 4 | ||
|
|
||
| num_thread = get_div(ftc, 128) | ||
|
|
||
| bx, outer_in = sch[real_output].split(a, factor=num_thread) | ||
|
|
||
| sch[real_output].bind(bx, te.thread_axis("blockIdx.x")) | ||
| sch[real_output].bind(outer_in, te.thread_axis("threadIdx.y")) | ||
| if is_idx_reduce: | ||
| sch[temp_idx_input].compute_at(sch[real_output], outer_in) | ||
| sch[temp_val_input].compute_at(sch[real_output], outer_in) | ||
|
|
||
|
|
||
| def schedule_reduce(outs): | ||
| return schedule_reduce_impl(outs, _schedule_reduce_adreno, schedule_injective_from_existing) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
tests/python/relay/opencl_texture/test_reduction_texture.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| import re | ||
| import tvm | ||
| import numpy as np | ||
| from tvm import relay | ||
| from tvm.relay import testing | ||
| from tvm.contrib import utils | ||
| from utils.adreno_utils import gpu_preprocess, build_run_compare | ||
|
|
||
|
|
||
| dtype = tvm.testing.parameter("float32") | ||
|
|
||
|
|
||
| @tvm.testing.requires_opencl | ||
| @tvm.testing.parametrize_targets("opencl -device=adreno") | ||
| def test_mean(target, dtype): | ||
| # NCHW | ||
| input_shape = (1, 3, 720, 1280) | ||
| A = relay.var("data", shape=input_shape, dtype=dtype) | ||
| mean = relay.mean(A, axis=1, keepdims=True) | ||
| mod = relay.Function([A], mean) | ||
|
|
||
| build_run_compare(mod, {}, {"data": input_shape}, dtype, target) | ||
|
|
||
|
|
||
| @tvm.testing.requires_opencl | ||
| @tvm.testing.parametrize_targets("opencl -device=adreno") | ||
| def test_argmax(target, dtype): | ||
| # NCHW | ||
| input_shape = (1, 3, 720, 1280) | ||
| A = relay.var("data", shape=input_shape, dtype=dtype) | ||
| argmax = relay.op.argmax(A, axis=[1]) | ||
| mod = relay.Function([A], argmax) | ||
|
|
||
| build_run_compare(mod, {}, {"data": input_shape}, dtype, target) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.