Skip to content

[skip ci] Fix RVM build#11771

Closed
areusch wants to merge 1 commit into
apache:mainfrom
areusch:fix-rvm-build
Closed

[skip ci] Fix RVM build#11771
areusch wants to merge 1 commit into
apache:mainfrom
areusch:fix-rvm-build

Conversation

@areusch

@areusch areusch commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

Fix missing apt-install-and-clear utility clobbered by #11753.

Skipping ci because nothing in this PR is tested in CI.

cc @mehrdadh

@github-actions github-actions Bot requested a review from mehrdadh June 17, 2022 21:38
@github-actions

Copy link
Copy Markdown
Contributor

Built docs for commit b1d705d1d1326e7b94481da1a4210544ac1242b2 can be found here.

@leandron leandron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the sake of consistency, while I acknowledge you fix is trivial, and shouldn't do any harm to the code base, I don't think the usage of the [skip ci] here applies within the agreed rules, given this change is not "un-breaking" CI.

Can you rename this PR and trigger CI again, so that we preserve the usage to the accepted/agreed use cases?

@leandron

Copy link
Copy Markdown
Contributor

cc @driazati

@mehrdadh

Copy link
Copy Markdown
Member

This is a duplicate of this one:
#11781
Maybe we can close this one since the other PR also does some renaming in the build script.

@areusch

areusch commented Jun 21, 2022

Copy link
Copy Markdown
Contributor Author

@mehrdadh sgtm. @leandron apologies for the abuse. agreed and will close this one.

@areusch areusch closed this Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants