[TVMC] Fix tvmc run when using rpc#11757
Merged
Merged
Conversation
As described in apache#11707, the RPC mechanism does not support objects of type Map which breaks the use of tvmc run when using RPC after apache#9889. This commit intends to workaround this issue by providing a fallback to the old implementation when RPC is being used. Further, a test has been provided to help prevent this regression in the future. Change-Id: I70c1863d00098270e27c08ba834a3587e9132d69
lhutton1
added a commit
to lhutton1/tvm
that referenced
this pull request
Jun 21, 2022
* [TVMC] Fix tvmc run when using rpc As described in apache#11707, the RPC mechanism does not support objects of type Map which breaks the use of tvmc run when using RPC after apache#9889. This commit intends to workaround this issue by providing a fallback to the old implementation when RPC is being used. Further, a test has been provided to help prevent this regression in the future. Change-Id: I70c1863d00098270e27c08ba834a3587e9132d69 * fix lint Change-Id: I958cf4e19988d047bdd2e02f6475b9f70afe80c8
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
* [TVMC] Fix tvmc run when using rpc As described in apache#11707, the RPC mechanism does not support objects of type Map which breaks the use of tvmc run when using RPC after apache#9889. This commit intends to workaround this issue by providing a fallback to the old implementation when RPC is being used. Further, a test has been provided to help prevent this regression in the future. Change-Id: I70c1863d00098270e27c08ba834a3587e9132d69 * fix lint Change-Id: I958cf4e19988d047bdd2e02f6475b9f70afe80c8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #11707, the RPC mechanism does not support objects of type Map which breaks the use of tvmc run when using RPC after #9889. This commit intends to workaround this issue by providing a fallback to the old implementation when RPC is being used. Further, a test has been provided to help prevent this regression in the future.
cc @leandron @leeexyz @masahi @Mousius @gromero