Skip to content

[Fix] int32/64 mismatch of buffer elem_offset at HandleBufferBindScope#11755

Merged
junrushao merged 10 commits into
apache:mainfrom
ganler:fix-int-mismatch-buffbind
Jun 22, 2022
Merged

[Fix] int32/64 mismatch of buffer elem_offset at HandleBufferBindScope#11755
junrushao merged 10 commits into
apache:mainfrom
ganler:fix-int-mismatch-buffbind

Conversation

@ganler

@ganler ganler commented Jun 16, 2022

Copy link
Copy Markdown
Contributor

Yet another int64/32 mismatch at TIR level. ArgBinder::Bind_ requires elem_offset of arg & view to have the same dtype while int64-broadcast-concat produce int64 elem_offset. cc: @masahi

@junrushao junrushao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ganler

ganler commented Jun 17, 2022

Copy link
Copy Markdown
Contributor Author

Oh i should have check .defined() first.

@ganler

ganler commented Jun 22, 2022

Copy link
Copy Markdown
Contributor Author

@junrushao1994 Eventually passed the CI. Sorry for the latency.

@junrushao junrushao merged commit c334790 into apache:main Jun 22, 2022
@junrushao

Copy link
Copy Markdown
Member

Thanks!! @ganler

blackkker pushed a commit to blackkker/tvm that referenced this pull request Jul 7, 2022
apache#11755)

Yet another int64/32 mismatch at TIR level. `ArgBinder::Bind_` requires `elem_offset` of arg & view to have the same dtype while `int64-broadcast-concat` produce int64 `elem_offset`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants