[PASS] Refactor a couple of TIR passes - BindTarget, AnnotateEntryFunc, Filter, LowerInitBlock#11628
Merged
Merged
Conversation
junrushao
reviewed
Jun 9, 2022
| #ifndef TVM_TIR_TRANSFORM_H_ | ||
| #define TVM_TIR_TRANSFORM_H_ | ||
|
|
||
| #include <tvm/driver/driver_api.h> |
Member
There was a problem hiding this comment.
Is it possible that we don't depend on driver_api.h?
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing out! Changed to #include <tvm/target/target.h> which is more accurate.
junrushao
reviewed
Jun 9, 2022
| */ | ||
|
|
||
| /*! | ||
| * \file helpers.cc |
Member
There was a problem hiding this comment.
we might want to find better names other than helpers.cc. For example, driver_api_pass.cc
Contributor
Author
There was a problem hiding this comment.
Agreed. How about the primfunc_utils.cc?
Member
There was a problem hiding this comment.
that sounds a reasonable choice!
junrushao
approved these changes
Jun 9, 2022
junrushao
left a comment
junrushao
left a comment
Member
There was a problem hiding this comment.
Overall the PR looks in a good state! Please address my nitpicks and let's get it merged sooooon!
Kathryn-cat
pushed a commit
to Kathryn-cat/tvm
that referenced
this pull request
Jun 10, 2022
…c, Filter, LowerInitBlock (apache#11628) This PR fixes a few inconsistent pass registration and add testcases for them. - `LowerInitBlock` had mismatch between its pass name and ffi key. - `BindTarget`, `AnnotateEntryFunc`, `Filter` were not following the name convention of tir passes and they were not registered in FFI registry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few inconsistent pass registration and add testcases for them.
LowerInitBlockhad mismatch between its pass name and ffi key.BindTarget,AnnotateEntryFunc,Filterwere not following the name convention of tir passes and they were not registered in FFI registry.cc. @junrushao1994