[Relay] Restore dominator check#11616
Merged
Merged
Conversation
I goofed in apache#11481 in moving a dominates check to an ICHECK (and I'm confused how it got through ci?). It is ok to match a sub-graph which has dataflow outside of the sub-graph, provided all such flows eventually come into the sub-graph.
Contributor
Author
|
Trying to come up with a unit test. |
Contributor
Author
|
Now with unit test. |
jroesch
approved these changes
Jun 8, 2022
Mousius
approved these changes
Jun 8, 2022
Member
|
LGTM @mbs-octoml 😸 |
Kathryn-cat
pushed a commit
to Kathryn-cat/tvm
that referenced
this pull request
Jun 10, 2022
It is ok to match a sub-graph which has dataflow outside of the sub-graph, provided all such flows eventually come into the sub-graph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I goofed in #11481 in moving a dominates check to
an ICHECK (and I'm confused how it got through ci?).
It is ok to match a sub-graph which has dataflow
outside of the sub-graph, provided all such flows
eventually come back into the sub-graph.