[HEXAGON] Slice ops added - add, subtract, multiply#11529
Conversation
|
@trahman-quic please fix the lint issue. |
trahman-quic
force-pushed
the
trahman-quic/sliced-add-sub-mul
branch
from
6fb6b0a to
f90a664
Compare
trahman-quic
changed the title
trahman-quic
force-pushed
the
trahman-quic/sliced-add-sub-mul
branch
from
f90a664 to
009e536
Compare
|
Hi @mehrdadh, looks like my PR passed all the checks. Is it good to merge now? |
|
let's wait for this(#11613) and rerun this PR |
mehrdadh
left a comment
mehrdadh
left a comment
There was a problem hiding this comment.
Overall looks good. I added few comments
| @@ -0,0 +1,230 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
please move this file to tests/python/contrib/test_hexagon/topi/
|
|
||
|
|
||
| def n11c_1024c_1d(n, h, w, c): | ||
| """Return index map for n11c_1024 1d layout""" |
There was a problem hiding this comment.
@mehrdadh I am having the same lint error about argument variable "w" here as well.
There was a problem hiding this comment.
since these are utility functions, it would be great if you can use better naming.
| output_transformed_layout = get_layout_transform_fn(output_layout) | ||
| s.transform_layout(block, buffer=("write", 0), index_map=output_transformed_layout) | ||
|
|
||
| n, h, w, c = s.get_loops(block) |
There was a problem hiding this comment.
@mehrdadh lint error is complaining about the variable name "w". It's not complaining about "n" or "h" or "c". Is it a reasonable error? Is there a way to stick to these simple(single letter) variable names?
There was a problem hiding this comment.
you're right. we might need to add pylint disable in this file.
trahman-quic
force-pushed
the
trahman-quic/sliced-add-sub-mul
branch
from
db9be6b to
1744403
Compare
trahman-quic
force-pushed
the
trahman-quic/sliced-add-sub-mul
branch
from
1744403 to
188fe44
Compare
trahman-quic
force-pushed
the
trahman-quic/sliced-add-sub-mul
branch
from
87b5dc4 to
1a9e0eb
Compare
|
Hi @mehrdadh, I merged main branch into my branch and the hexagon tests are passing now. But now it's failing on a QEMU test. Could you please give me some ideas on what might be causing this? |
|
@trahman-quic I think this was resolved. Could you rebase and push to run the job? |
trahman-quic
force-pushed
the
trahman-quic/sliced-add-sub-mul
branch
from
1a9e0eb to
6bacd64
Compare
trahman-quic
force-pushed
the
trahman-quic/sliced-add-sub-mul
branch
from
6bacd64 to
6bc4d4a
Compare
|
Hi @mehrdadh, all the tests are passing now. Pinging you to see if it is good to merge now. |
|
@trahman-quic PR is merged now, thanks! |
* [UPSTREAM][HEXAGON] Slice ops added - add, subtract, multiply * Change to v68 * Change transform_numpy function call * Do not disbale pylint errors and fix them * Fix variable names * Move the test file to topi * Resolve conflict * Modify init
2 participants
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.
cc @mehrdadh