[microNPU] add E2E tests with cascader wo striping#11410
Merged
Conversation
Contributor
Author
NicolaLancellotti
approved these changes
May 25, 2022
manupak
force-pushed
the
enabling_cascader_wo_striping
branch
from
8d61cf2 to
98280d3
Compare
manupak
force-pushed
the
enabling_cascader_wo_striping
branch
2 times, most recently
from
bd9fb59 to
3556b2a
Compare
This commit adds end-to-end tests using the cascader w/o striping. It needed few adjustments to the order in which the arugments are provided to the entry point function in AoT when both memory pools and devices are present. Change-Id: I37e04afd635add895e317586f628a62cae75f3fa
manupak
force-pushed
the
enabling_cascader_wo_striping
branch
from
3556b2a to
d80d96c
Compare
Contributor
Author
|
This is green now. :) |
Contributor
|
@ekalda @NicolaLancellotti could you take another look after the further changes to make sure you still approve? |
Contributor
|
LGTM! |
ekalda
approved these changes
May 30, 2022
ekalda
left a comment
ekalda
left a comment
Contributor
There was a problem hiding this comment.
Yeah still looks good to me :)
Contributor
|
Thanks @manupa-arm @NicolaLancellotti @ekalda! |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds end-to-end tests using the cascader
w/o striping. It needed few adjustments to the order
in which the arugments are provided to the entry point
function in AoT when both memory pools and devices
are present.
cc @Mousius @lhutton1