Add utility to replace direct call to pytest.main#11393
Merged
Conversation
Contributor
Author
areusch
reviewed
May 20, 2022
areusch
left a comment
areusch
left a comment
Contributor
There was a problem hiding this comment.
thanks @gigiblender this looks great! one request here
gigiblender
force-pushed
the
pytest-main-remove
branch
from
48e81c7 to
d70f300
Compare
Contributor
Author
@areusch I pushed the requested changes. |
driazati
reviewed
May 23, 2022
driazati
left a comment
driazati
left a comment
Member
There was a problem hiding this comment.
nice! just one small comment
|
|
||
| def main(): | ||
| test_file = inspect.getsourcefile(sys._getframe(1)) | ||
| sys.exit(pytest.main([test_file] + sys.argv[1:])) |
Member
There was a problem hiding this comment.
just a nit but do we actually need to determine and pass in the test file name? the examples don't seem to need it
Suggested change
| sys.exit(pytest.main([test_file] + sys.argv[1:])) | |
| sys.exit(pytest.main(sys.argv[1:])) |
Contributor
Author
There was a problem hiding this comment.
I think running without a specified test file will cause pytest to search the current file for tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the test call to
pytest.mainwith a call to a utility function:
#11318