[microTVM][ARM] Add Relay tests for conv2d registered schedules#11250
Conversation
|
cc @mkatanbaf |
mehrdadh
force-pushed
the
microtvm/add_conv2d_tests
branch
4 times, most recently
from
3d6106d to
0a19a88
Compare
|
cc @areusch |
areusch
left a comment
areusch
left a comment
There was a problem hiding this comment.
thanks @mehrdadh ! i think this is a good utility that can be used to run integration tests. thinking about it a bit more, i think that we may want to complement this with a faster unit test infrastructure, but that we could proceed with it for writing micro tests since these need the tvm.relay.build() output to work with Project API for now.
cc @tqchen @junrushao1994 if they could comment more on the intended way that someone could verify in test that a given schedule was part of the operator strategy for a particular Target.
| Name of schedule to use. | ||
| """ | ||
|
|
||
| def __init__(self, tasks, schedule_name: str): |
There was a problem hiding this comment.
for schedule_name, should we be taking a mapping here, e.g. a dict mapping compute function name to schedule or something?
There was a problem hiding this comment.
i think this would get called for each function being scheduled. so if the Relay program was more complex (e.g. task extraction found multiple tasks), then we'd want to specify a schedule for each.
| compiled_mods.append( | ||
| AOTCompiledTestModel(model=model, executor_factory=executor_factory) | ||
| ) | ||
| if schedule_name: |
There was a problem hiding this comment.
could we add some kind of assert here to verify that tvm.relay.build actually chose this schedule?
There was a problem hiding this comment.
I don't think there's a way to do that from AOTExecutorFactoryModule
There was a problem hiding this comment.
i was thinking we could do something like search the output function names here.
There was a problem hiding this comment.
We can iterate on this in a follow up PR. thanks!
|
|
||
|
|
||
| class ApplyFixedConfig(DispatchContext): | ||
| """Apply a config of a deterministic schedule. |
There was a problem hiding this comment.
could you explain why this is different from ApplyConfig here?
There was a problem hiding this comment.
i think the comment no longer makes sense now that we are accepting an array of schedule names, but can fix that in a follow-on.
There was a problem hiding this comment.
will fix that in a follow up PR.
Enable relay tests in qemu
mehrdadh
force-pushed
the
microtvm/add_conv2d_tests
branch
from
152c1aa to
76c44fd
Compare
|
@areusch PTAL, thanks |
|
@mehrdadh just replied on the one thread, lmk if that makes sense |
|
|
||
|
|
||
| class ApplyFixedConfig(DispatchContext): | ||
| """Apply a config of a deterministic schedule. |
There was a problem hiding this comment.
i think the comment no longer makes sense now that we are accepting an array of schedule names, but can fix that in a follow-on.
3 participants
This PR does the following changes:
cc @gromero