[Android] Update gradle version and other changes in android apps, CI modification to auto-build Android apps and upload artifacts#11241
Merged
Conversation
…ors, disable some of them
Contributor
Author
argrento
changed the title
|
@Lyken17 Please take a look at it. |
tmoreau89
reviewed
May 17, 2022
tmoreau89
left a comment
tmoreau89
left a comment
Contributor
There was a problem hiding this comment.
Thank you @argrento for keeping the android RPC app up to date and functional. Let @KJlaccHoeUM9l if the feedback can be addressed!
argrento
changed the title
tmoreau89
approved these changes
May 23, 2022
tmoreau89
left a comment
tmoreau89
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing the comments, LGTM
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update gradle configs to remove errors described in https://discuss.tvm.apache.org/t/gradle-build-fail-for-android-rpc-demo/10493
Modified:
Also add CI jobs to build apps and keep artifacts.
Previous PR: #10867