[TIR] Add schedule primitive SetAxisSeparator#11225
Conversation
d4d31d5 to
e59b977
Compare
Lunderberg
left a comment
There was a problem hiding this comment.
This looks fantastic! I really like the ReplaceBufferMutator utility, and look forward to using it elsewhere as well!
|
@Lunderberg @vinx13 This is great, thanks a lot, I would love to start using this. I do have a small doubt however. Is there a reason why we're introducing a new schedule primitive instead of allowing the user to pass something similar to The reason for this question is that the list to be passed to |
csullivan
left a comment
There was a problem hiding this comment.
Thank you for adding axis separator support to TIR scheduling! I also really love ReplaceBufferMutator, not only very useful but edifying as a concise description of all the places buffer rewrites may need to occur. Just a few comments, only one really needs addressing.
|
@quic-sanirudh Thanks for the comments. The motivation to have a separate schedule primitive is to decouple the logical-physical mapping from generic layout transformation which doesn't have to deal with physical layout. @Lunderberg suggested that we can have a user convenience API backed by these two schedule primitives |
Ah okay, thanks for the reply @vinx13 |
|
Many thanks @vinx13 @quic-sanirudh @junrushao1994 @Lunderberg, this is merged! |
* [TIR] Add schedule primitive SetAxisSeparator * remove unused include * Move ReplaceBufferMutator impl to cc file
* [TIR] Add schedule primitive SetAxisSeparator * remove unused include * Move ReplaceBufferMutator impl to cc file
This PR added a schedule primitive
set_axis_separator, it modifiesaxis_separatorsattribute of the target buffer, which affects the physical dimension after flattening.cc @Lunderberg @csullivan @junrushao1994