Skip to content

Add unidirectional sequence lstm#11183

Merged
AndrewZhaoLuo merged 16 commits into
apache:mainfrom
SebastianBoblest:addUnidirectionalSequenceLSTM
May 27, 2022
Merged

Add unidirectional sequence lstm#11183
AndrewZhaoLuo merged 16 commits into
apache:mainfrom
SebastianBoblest:addUnidirectionalSequenceLSTM

Conversation

@SebastianBoblest

Copy link
Copy Markdown
Contributor

This work has mostly been done by @vdkhoi Khoi Duy Vo from ETAS Gmbh.
We add parser support for UnidirectionalSequenceLSTM layers in tflite.

A question regarding the test:
At the moment it uses a toy model that I store in a repo in my github account.
Should we copy this to the TVM repo or what is the best way to do this?

Comment thread python/tvm/relay/frontend/tflite.py Outdated
Comment thread python/tvm/relay/frontend/tflite.py Outdated
Comment thread python/tvm/relay/frontend/tflite.py Outdated
@vdkhoi

vdkhoi commented May 4, 2022

Copy link
Copy Markdown

All tests passed

Comment thread tests/python/frontend/tflite/test_forward.py Outdated
Comment thread python/tvm/relay/frontend/tflite.py Outdated
@SebastianBoblest

Copy link
Copy Markdown
Contributor Author

Now this fails on windows. I restarted the CI pipeline three times. Does not seem to be related to our changes. Should or could we do anything to resolve this?

@Mousius

Mousius commented May 5, 2022

Copy link
Copy Markdown
Member

@SebastianBoblestETAS I think this is effecting more than just this PR, I've raised #11220 to track it, please stand by 😸

Comment thread python/tvm/relay/frontend/tflite.py
Comment thread python/tvm/relay/frontend/tflite.py
Comment thread python/tvm/relay/frontend/tflite.py Outdated
Comment thread python/tvm/relay/frontend/tflite.py

@huajsj huajsj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, thanks @SebastianBoblestETAS, @vdkhoi.

@SebastianBoblest

Copy link
Copy Markdown
Contributor Author

@Mousius Hi, sorry this is again failing but in a totally different place now.
Should we simply wait or trigger the CI/CD again?

@SebastianBoblest

Copy link
Copy Markdown
Contributor Author

There is still the issue of the model we use in the tests.
Where should we put it?
@huajsj Is your approval not enough for this to get merged?

@Mousius

Mousius commented May 11, 2022

Copy link
Copy Markdown
Member

@SebastianBoblestETAS I re-ran the CI yesterday and it looks green, though I don't really know that much about this PR other than the CI issues - maybe @leandron can help get this merged? 😸

@SebastianBoblest

Copy link
Copy Markdown
Contributor Author

@leandron Hi, could you maybe help with getting this merged?
The issue that still should get resolved however is that our test uses a model that I have stored in a repo in my own github profile.
Other tests seem to use models from public model zoos. But for our case we would prefer a sample model that only has a UnidirectionalSequenceLSTM layer. Should we put it in a data folder in TVM or what would you suggest?

@vdkhoi

vdkhoi commented May 12, 2022

Copy link
Copy Markdown

@junrushao1994 Hi, could you also have a look on our PR and help to make it merged? Thanks.

@SebastianBoblest

Copy link
Copy Markdown
Contributor Author

@mbrookhart @jwfromm @Huyuwei @hlu1 @AndrewZhaoLuo @kazum @siju-samuel @srkreddy1238 @FrozenGene
Hi all,
could someone of you help us with this PR?
Sorry to bother all of you, I just looked in CONTRIBUTORS.md for all committers that are familiar with frontends.
Thanks in advance!

@AndrewZhaoLuo AndrewZhaoLuo self-assigned this May 18, 2022
@AndrewZhaoLuo

Copy link
Copy Markdown
Contributor

Ill take a look tomorrow

@vdkhoi

vdkhoi commented May 23, 2022

Copy link
Copy Markdown

Ill take a look tomorrow

@AndrewZhaoLuo did you review our PR? We are ready to answer your question.

@AndrewZhaoLuo AndrewZhaoLuo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for getting back to you late. LGTM!

Comment thread python/tvm/relay/frontend/tflite.py Outdated
@vdkhoi

vdkhoi commented May 24, 2022

Copy link
Copy Markdown

@Mousius We just add some comments as request from @AndrewZhaoLuo, but the tvm-ci failed again. Could you please support us to restart it?

@AndrewZhaoLuo

AndrewZhaoLuo commented May 24, 2022

Copy link
Copy Markdown
Contributor

@vdkhoi you can restart CI by pushing an empty commit.

e.g.
git commit --allow-empty "jostle-ci" and git push

@SebastianBoblest

Copy link
Copy Markdown
Contributor Author

@AndrewZhaoLuo I updated the comment in the function and made it more precise.
The most important difference of the two "unbind" versions is actually that the onnx-Version takes a exp.Call object and the one in tflite a tvm.relay.frontend.tflite.TensorWrapper. So inferring the shape also works differently.

@AndrewZhaoLuo

AndrewZhaoLuo commented May 25, 2022

Copy link
Copy Markdown
Contributor

Sometimes you also need to rebase on main to solve flaky CI issues :/ . Sorry about that

@SebastianBoblest SebastianBoblest force-pushed the addUnidirectionalSequenceLSTM branch from ccfbebd to efecbcd Compare May 27, 2022 11:47
@SebastianBoblest

Copy link
Copy Markdown
Contributor Author

@AndrewZhaoLuo I just rebased. Let's hope for the best 😄

@AndrewZhaoLuo

Copy link
Copy Markdown
Contributor

Thanks! Sorry this took a long time to get merged.

@AndrewZhaoLuo AndrewZhaoLuo merged commit 7766ab2 into apache:main May 27, 2022
@vdkhoi

vdkhoi commented May 27, 2022

Copy link
Copy Markdown

Thanks! Sorry this took a long time to get merged.

Thank you. Finally :) it done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants