Skip to content

[TRT] Add check to support split op with TRT 5.1.5+#11154

Merged
comaniac merged 1 commit into
apache:mainfrom
apivovarov:trt_split_515
May 2, 2022
Merged

[TRT] Add check to support split op with TRT 5.1.5+#11154
comaniac merged 1 commit into
apache:mainfrom
apivovarov:trt_split_515

Conversation

@apivovarov

@apivovarov apivovarov commented Apr 27, 2022

Copy link
Copy Markdown
Contributor

SplitOpConverter uses nvinfer1::INetworkDefinition::addSlice which is not available before TRT 5.1.5
This PR adds a check to support split op with TRT 5.1.5+

Related PR: #7967

@apivovarov

Copy link
Copy Markdown
Contributor Author

@comaniac @ziyu-guo Can you have a look?

@ziyu-guo ziyu-guo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comaniac

Copy link
Copy Markdown
Contributor

LGTM. Please also update the document: https://tvm.apache.org/docs/how_to/deploy/tensorrt.html

@apivovarov

Copy link
Copy Markdown
Contributor Author

LGTM. Please also update the document: https://tvm.apache.org/docs/how_to/deploy/tensorrt.html

Done. Added conv1d op to Operator support table as well.

@apivovarov

Copy link
Copy Markdown
Contributor Author

@masahi @vinx13 @comaniac Can you merge it?

@comaniac comaniac merged commit 9284d32 into apache:main May 2, 2022
@comaniac

comaniac commented May 2, 2022

Copy link
Copy Markdown
Contributor

Thanks @apivovarov @ziyu-guo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants