[Metaschedule, Refactor] Move MultiLevelTilingNode decl to a header#11020
Merged
Conversation
Hzfengsy
approved these changes
Apr 15, 2022
junrushao
reviewed
Apr 15, 2022
junrushao
reviewed
Apr 15, 2022
junrushao
approved these changes
Apr 15, 2022
junrushao
left a comment
junrushao
left a comment
Member
There was a problem hiding this comment.
Otherwise LGTM! Thanks for moving this around
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
altanh
pushed a commit
to altanh/tvm
that referenced
this pull request
Apr 28, 2022
…pache#11020) * [Metaschedule, Refactor] Move MultiLevelTilingNode decl to a header * cpplint * Update src/meta_schedule/schedule_rule/multi_level_tiling.cc Co-authored-by: Junru Shao <junrushao1994@gmail.com> * Update src/meta_schedule/schedule_rule/multi_level_tiling.cc Co-authored-by: Junru Shao <junrushao1994@gmail.com> * cpplint Co-authored-by: Junru Shao <junrushao1994@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
schedule_rule/multi_level_tiling.hheader and move the declaration ofMultiLevelTilingNode. The purpose is to be able to extend this class so that different tiling subrules can be easily added in a derived class (e.g. for auto-tensorization).I have an example of the derived class in https://github.com/masahi/tvm/blob/0602f4a3157d4cb5a3f280a3a3c514bb6535aac8/src/meta_schedule/schedule_rule/multi_level_tiling_with_intrin.cc#L27. It is used for VNNI, ARM and DP4A tensorization.
@jinhongyii @vinx13 @junrushao1994 @spectrometerHBH @Hzfengsy