[Graph Debugger] Expose way to benchmark individual nodes.#11000
Merged
Conversation
Contributor
Author
|
cc @tkonolige |
tkonolige
requested changes
Apr 18, 2022
tkonolige
left a comment
tkonolige
left a comment
Contributor
There was a problem hiding this comment.
This is a nice utility to have, thanks @AndrewZhaoLuo! Maybe we could add this to the VM too (although it doesn't have a concept of "node").
AndrewZhaoLuo
commented
Apr 18, 2022
AndrewZhaoLuo
left a comment
AndrewZhaoLuo
left a comment
Contributor
Author
There was a problem hiding this comment.
Thanks for the review! Have some questions about using time_evaluator though.
Contributor
Author
|
PTAL @tkonolige |
tkonolige
requested changes
Apr 25, 2022
tkonolige
left a comment
tkonolige
left a comment
Contributor
There was a problem hiding this comment.
The code look good, but could you add a test case?
Contributor
Author
Done |
tkonolige
requested changes
Apr 25, 2022
tkonolige
approved these changes
Apr 26, 2022
tkonolige
left a comment
tkonolige
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Not sure what is going on with CI.
AndrewZhaoLuo
force-pushed
the
aluo/run-individual-node
branch
from
096f026 to
7122525
Compare
AndrewZhaoLuo
force-pushed
the
aluo/run-individual-node
branch
from
7122525 to
e864722
Compare
masahi
approved these changes
Apr 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful if we only care about a single node or set of nodes in our graph we want to benchmark.
Associated example script of use: https://github.com/AndrewZhaoLuo/TVM-Sandbox/blob/main/runtime/test_benchmark_funcs_graph_runtime.py