Skip to content

[ci] Don't diff Python files when checking formatting#10895

Merged
Mousius merged 2 commits into
apache:mainfrom
driazati:nodiffblack
Apr 6, 2022
Merged

[ci] Don't diff Python files when checking formatting#10895
Mousius merged 2 commits into
apache:mainfrom
driazati:nodiffblack

Conversation

@driazati

@driazati driazati commented Apr 4, 2022

Copy link
Copy Markdown
Member

Following on from #10893, this removes the diffing logic before running black. The runtime penalty is minimal and this will ensure future changes are better tested. The first commit is the actual code changes, the second is the result of running the lint script against the repo.

cc @areusch @leandron

@driazati driazati marked this pull request as ready for review April 4, 2022 20:36
@github-actions github-actions Bot requested review from areusch and leandron April 4, 2022 20:37
@Mousius Mousius self-assigned this Apr 5, 2022

@junrushao junrushao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mousius Mousius merged commit 96f701f into apache:main Apr 6, 2022
areusch pushed a commit that referenced this pull request Apr 6, 2022
This was erroneously added in #10895

Co-authored-by: driazati <driazati@users.noreply.github.com>
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
This was erroneously added in apache#10895

Co-authored-by: driazati <driazati@users.noreply.github.com>
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Apr 11, 2022
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Apr 11, 2022
This was erroneously added in apache#10895

Co-authored-by: driazati <driazati@users.noreply.github.com>
altanh pushed a commit to altanh/tvm that referenced this pull request Apr 28, 2022
altanh pushed a commit to altanh/tvm that referenced this pull request Apr 28, 2022
This was erroneously added in apache#10895

Co-authored-by: driazati <driazati@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants