Skip to content

[TIR] Properly initialize PRNG seed when copying schedule#10806

Merged
masahi merged 3 commits into
apache:mainfrom
masahi:tir-sch-rng-copy
Mar 29, 2022
Merged

[TIR] Properly initialize PRNG seed when copying schedule#10806
masahi merged 3 commits into
apache:mainfrom
masahi:tir-sch-rng-copy

Conversation

@masahi

@masahi masahi commented Mar 28, 2022

Copy link
Copy Markdown
Member

Fixes the hang issue discussed in #10689 (comment)

@junrushao1994 @Hzfengsy

masahi added 3 commits March 29, 2022 07:35
commit eeb4a6d
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Tue Mar 29 06:39:38 2022 +0900

    add more comment

commit 183b4cf
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Mon Mar 28 10:04:12 2022 +0900

    skip flaky vk test

commit c19ecc1
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Mon Mar 28 07:34:25 2022 +0900

    move intrin decl for vector type

commit 3dd7f04
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 09:40:29 2022 +0900

    disable default post processor, tuning now works with compactness check

commit 2f6fdae
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 08:08:35 2022 +0900

    more comment

commit c7ebfa9
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 07:42:46 2022 +0900

    add comment

commit 78400ba
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 07:40:28 2022 +0900

    disable tuning test for now

commit a33243f
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 07:30:03 2022 +0900

    remove annotation check in ir comparator

commit 105f98c
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 07:28:36 2022 +0900

    clean up

commit 8aa16f2
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 07:15:24 2022 +0900

    Add test

@Hzfengsy Hzfengsy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix

@masahi masahi merged commit 62e3d9d into apache:main Mar 29, 2022
junrushao pushed a commit to junrushao/tvm that referenced this pull request Mar 29, 2022
* Make Schedule::Copy non-const, fork RND seed in Copy

* fork seed in traced schedule copy too

commit eeb4a6d
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Tue Mar 29 06:39:38 2022 +0900

    add more comment

commit 183b4cf
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Mon Mar 28 10:04:12 2022 +0900

    skip flaky vk test

commit c19ecc1
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Mon Mar 28 07:34:25 2022 +0900

    move intrin decl for vector type

commit 3dd7f04
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 09:40:29 2022 +0900

    disable default post processor, tuning now works with compactness check

commit 2f6fdae
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 08:08:35 2022 +0900

    more comment

commit c7ebfa9
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 07:42:46 2022 +0900

    add comment

commit 78400ba
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 07:40:28 2022 +0900

    disable tuning test for now

commit a33243f
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 07:30:03 2022 +0900

    remove annotation check in ir comparator

commit 105f98c
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 07:28:36 2022 +0900

    clean up

commit 8aa16f2
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 07:15:24 2022 +0900

    Add test

* add test case that hangs without forkseed
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
* Make Schedule::Copy non-const, fork RND seed in Copy

* fork seed in traced schedule copy too

commit eeb4a6d
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Tue Mar 29 06:39:38 2022 +0900

    add more comment

commit 183b4cf
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Mon Mar 28 10:04:12 2022 +0900

    skip flaky vk test

commit c19ecc1
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Mon Mar 28 07:34:25 2022 +0900

    move intrin decl for vector type

commit 3dd7f04
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 09:40:29 2022 +0900

    disable default post processor, tuning now works with compactness check

commit 2f6fdae
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 08:08:35 2022 +0900

    more comment

commit c7ebfa9
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 07:42:46 2022 +0900

    add comment

commit 78400ba
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 07:40:28 2022 +0900

    disable tuning test for now

commit a33243f
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 07:30:03 2022 +0900

    remove annotation check in ir comparator

commit 105f98c
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 07:28:36 2022 +0900

    clean up

commit 8aa16f2
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sat Mar 26 07:15:24 2022 +0900

    Add test

* add test case that hangs without forkseed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants