[TIR] Properly initialize PRNG seed when copying schedule#10806
Merged
Conversation
commit eeb4a6d Author: Masahiro Masuda <masahi129@gmail.com> Date: Tue Mar 29 06:39:38 2022 +0900 add more comment commit 183b4cf Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon Mar 28 10:04:12 2022 +0900 skip flaky vk test commit c19ecc1 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon Mar 28 07:34:25 2022 +0900 move intrin decl for vector type commit 3dd7f04 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 09:40:29 2022 +0900 disable default post processor, tuning now works with compactness check commit 2f6fdae Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 08:08:35 2022 +0900 more comment commit c7ebfa9 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 07:42:46 2022 +0900 add comment commit 78400ba Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 07:40:28 2022 +0900 disable tuning test for now commit a33243f Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 07:30:03 2022 +0900 remove annotation check in ir comparator commit 105f98c Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 07:28:36 2022 +0900 clean up commit 8aa16f2 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 07:15:24 2022 +0900 Add test
Hzfengsy
approved these changes
Mar 29, 2022
Hzfengsy
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for the quick fix
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Mar 29, 2022
* Make Schedule::Copy non-const, fork RND seed in Copy * fork seed in traced schedule copy too commit eeb4a6d Author: Masahiro Masuda <masahi129@gmail.com> Date: Tue Mar 29 06:39:38 2022 +0900 add more comment commit 183b4cf Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon Mar 28 10:04:12 2022 +0900 skip flaky vk test commit c19ecc1 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon Mar 28 07:34:25 2022 +0900 move intrin decl for vector type commit 3dd7f04 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 09:40:29 2022 +0900 disable default post processor, tuning now works with compactness check commit 2f6fdae Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 08:08:35 2022 +0900 more comment commit c7ebfa9 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 07:42:46 2022 +0900 add comment commit 78400ba Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 07:40:28 2022 +0900 disable tuning test for now commit a33243f Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 07:30:03 2022 +0900 remove annotation check in ir comparator commit 105f98c Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 07:28:36 2022 +0900 clean up commit 8aa16f2 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 07:15:24 2022 +0900 Add test * add test case that hangs without forkseed
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* Make Schedule::Copy non-const, fork RND seed in Copy * fork seed in traced schedule copy too commit eeb4a6d Author: Masahiro Masuda <masahi129@gmail.com> Date: Tue Mar 29 06:39:38 2022 +0900 add more comment commit 183b4cf Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon Mar 28 10:04:12 2022 +0900 skip flaky vk test commit c19ecc1 Author: Masahiro Masuda <masahi129@gmail.com> Date: Mon Mar 28 07:34:25 2022 +0900 move intrin decl for vector type commit 3dd7f04 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 09:40:29 2022 +0900 disable default post processor, tuning now works with compactness check commit 2f6fdae Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 08:08:35 2022 +0900 more comment commit c7ebfa9 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 07:42:46 2022 +0900 add comment commit 78400ba Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 07:40:28 2022 +0900 disable tuning test for now commit a33243f Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 07:30:03 2022 +0900 remove annotation check in ir comparator commit 105f98c Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 07:28:36 2022 +0900 clean up commit 8aa16f2 Author: Masahiro Masuda <masahi129@gmail.com> Date: Sat Mar 26 07:15:24 2022 +0900 Add test * add test case that hangs without forkseed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the hang issue discussed in #10689 (comment)
@junrushao1994 @Hzfengsy