[QNN] Add per-channel quantization to add/subtract/multiply#10718
Merged
Conversation
Contributor
Author
|
@AndrewZhaoLuo @anwang2009 @mbrookhart please review |
anwang2009
approved these changes
Mar 23, 2022
anwang2009
left a comment
anwang2009
left a comment
Contributor
There was a problem hiding this comment.
just some nits, LGTM!
AndrewZhaoLuo
left a comment
AndrewZhaoLuo
left a comment
Contributor
There was a problem hiding this comment.
Will read a bit more deeply tomorrow
AndrewZhaoLuo
approved these changes
Mar 29, 2022
AndrewZhaoLuo
left a comment
AndrewZhaoLuo
left a comment
Contributor
There was a problem hiding this comment.
LGTM, please take a look at the failing tests.
sfvaroglu
force-pushed
the
sevin/bcast_per_channel
branch
from
e3d2b35 to
89910c6
Compare
Contributor
|
@sfvaroglu what's the status of this PR? |
Contributor
Author
|
I'm trying to fix the failing test. I couldn't reproduce locally (no arm-cpu), so it's going slow. |
sfvaroglu
force-pushed
the
sevin/bcast_per_channel
branch
from
8d86cd3 to
dda96a3
Compare
Contributor
Author
|
@AndrewZhaoLuo This PR is ready to go. |
Contributor
|
LGTM, thanks for this @sfvaroglu B) |
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
…0718) * Add per-channel quantization to QNN add/subtract/multiply * Add feedback * Add feedback - round 2 * Fix for arm test * Add params to the test * Try again * Try int * Move lhs_axis and rhs_axis * Add as an attribute * Add quotes
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Apr 11, 2022
…0718) * Add per-channel quantization to QNN add/subtract/multiply * Add feedback * Add feedback - round 2 * Fix for arm test * Add params to the test * Try again * Try int * Move lhs_axis and rhs_axis * Add as an attribute * Add quotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for per-channel quantization for broadcast ops (add/subtract/multiply).