[Refactor] Reduced repetition in CodeGenLLVM's buffer access#10567
Merged
masahi merged 3 commits intoMar 11, 2022
Conversation
Previously, the majority of the BufferLoad and BufferStore visitors were duplicate logic to handle the indexing. After this commit, the shared logic is extracted out into a helper function.
Lunderberg
requested review from
ZihengJiang,
junrushao,
kparzysz-quic,
masahi,
tqchen and
vinx13
as code owners
Contributor
Author
|
Bump to CI, previous CI run failed due to HTTP timeout connecting to https://matplotlib.org/objects.inv |
masahi
approved these changes
Mar 11, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
…10567) * [Refactor] Reduced repetition in CodeGenLLVM's buffer access Previously, the majority of the BufferLoad and BufferStore visitors were duplicate logic to handle the indexing. After this commit, the shared logic is extracted out into a helper function. * Fixup, remove declaration of unused variable. * Bump to CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the majority of the BufferLoad and BufferStore visitors were duplicate logic to handle the indexing. After this commit, the shared logic is extracted out into a helper function.
This is in preparation for changes in
CodeGenHexagon, which is subclassed fromCodeGenLLVMand will use 2-d buffers.