[AOT] Use python temporary directory for AOT tests#10518
Merged
Conversation
lhutton1
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
lhutton1
commented
Mar 7, 2022
manupak
requested changes
Mar 8, 2022
Uses a python temporary directory with a context manager in an effort to solve the flaky FVP tests raised in apache#10300 and apache#10314. Now that CI is becoming more and more parallelized, the thinking is that the python temporary directory implementation might be more stable than `utils.tempdir`. Removing the XFail markings off the affected tests, but keeping the work around implemented in apache#10408 while we monitor with the above change. Change-Id: Id07869b51cd2278ec4885ef964bc1b23892ba235
lhutton1
force-pushed
the
enable-flaky-tests
branch
from
e12d6ba to
b33e292
Compare
lhutton1
force-pushed
the
enable-flaky-tests
branch
2 times, most recently
from
d7a8aa8 to
644b273
Compare
lhutton1
force-pushed
the
enable-flaky-tests
branch
from
644b273 to
6b42f15
Compare
Change-Id: Iba0644db14e50648f6dc99a4ed0f455641c31912
lhutton1
force-pushed
the
enable-flaky-tests
branch
from
6b42f15 to
b2e51c0
Compare
Contributor
|
Thanks @lhutton1 . This is merged now! |
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* [AOT] Use python temporary directory for AOT tests Uses a python temporary directory with a context manager in an effort to solve the flaky FVP tests raised in apache#10300 and apache#10314. Now that CI is becoming more and more parallelized, the thinking is that the python temporary directory implementation might be more stable than `utils.tempdir`. Removing the XFail markings off the affected tests, but keeping the work around implemented in apache#10408 while we monitor with the above change. Change-Id: Id07869b51cd2278ec4885ef964bc1b23892ba235 * alter context manager to make more readable Change-Id: Iba0644db14e50648f6dc99a4ed0f455641c31912
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses a python temporary directory with a context manager in an effort to solve the flaky FVP tests raised in #10300 and #10314. Now that CI is becoming more and more parallelized, the thinking is that the python temporary directory implementation might be more stable than
utils.tempdir. Removing the XFail markings off the affected tests, but keeping the work around implemented in #10408 while we monitor with the above change.cc @manupa-arm @ekalda @grant-arm @Mousius