[Hexagon] RPC server/client for simulator#10361
Merged
Merged
Conversation
This is the C++ code for running Hexagon code on simulator via the RPC mechanism. It is intended to be integrated into the current HexagonLauncher, although the integration will require further changes to the launcher python code. The final goal is to be able to run the same file.py on either hardware or simulator without needing to edit the python file, but simply by changing the configuration of the execution platform (i.e. something like --exectute-on=simulator as a command line or in an environment variable). The exact details are still to be determined.
kparzysz-quic
requested review from
ZihengJiang,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
kazum,
liangfu,
masahi,
tmoreau89,
tqchen,
vinx13,
yzhliu and
zhiics
as code owners
Contributor
Author
|
cc: @mehrdadh |
kparzysz-quic
commented
Feb 23, 2022
| # Build X86 binaries: | ||
| # - tvm_rpc_x86 | ||
|
|
||
| ExternalProject_Add(x86_tvm_runtime_rpc |
Contributor
Author
There was a problem hiding this comment.
Build a cpp RPC server app for x86 with the Hexagon RPC code enabled.
kparzysz-quic
commented
Feb 23, 2022
| HEX_VA_t dispatch_v_, message_buffer_v_; | ||
| std::unique_ptr<HexagonWrapper> sim_; | ||
|
|
||
| // Sim configuration routines. |
Contributor
Author
There was a problem hiding this comment.
All of this configuration code was taken from src/runtime/hexagon/android/sim/hexagon_device_sim.cpp.
Member
There was a problem hiding this comment.
can you move all of these configurations to a header file and reuse it?
Contributor
Author
There was a problem hiding this comment.
The offload code will be removed, so this will be the only place where it appears. The files in src/runtime/hexagon/android will be deleted.
Member
There was a problem hiding this comment.
@mehrdadh Since the original code will be removed, I think it's fine to merge this as is and let @kparzysz-quic continue completing his work.
masahi
approved these changes
Feb 24, 2022
| rpc->dispatch_v_ = RssV & ~0u; // ~0u is uint32_t | ||
| rpc->message_buffer_v_ = RssV >> 32; | ||
|
|
||
| LOG(INFO) << "dispatch:" << reinterpret_cast<void*>(rpc->dispatch_v_) |
Member
There was a problem hiding this comment.
DLOG or VLOG (can be done in a follow up)
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
This is the C++ code for running Hexagon code on simulator via the RPC mechanism. It is intended to be integrated into the current HexagonLauncher, although the integration will require further changes to the launcher python code. The final goal is to be able to run the same file.py on either hardware or simulator without needing to edit the python file, but simply by changing the configuration of the execution platform (i.e. something like --exectute-on=simulator as a command line or in an environment variable). The exact details are still to be determined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the C++ code for running Hexagon code on simulator via the RPC mechanism. It is intended to be integrated into the current
HexagonLauncher, although the integration will require further changes to the launcher python code.The final goal is to be able to run the same file.py on either hardware or simulator without needing to edit the python file, but simply by changing the configuration of the execution platform (i.e. something like
--execute-on=simulatoras a command line or in an environment variable). The exact details are still to be determined.