[Runtime] Improved log information with function signature#10326
Merged
Conversation
junrushao
reviewed
Feb 20, 2022
Member
|
@cyx-6 Would you mind if you could demonstrate what the new error messages look like? |
Contributor
Author
|
@junrushao1994 Sure. Here is an example for new error message:
If we wrongly call function |
Member
|
Thanks! Would it be clearer to also show the index like below? Thanks a lot! |
Contributor
Author
|
The code has been updated. It looks much clearer now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a function signature printer in the
TypedPackedFuncpart, so that the log information indetail::unpack_callwill be more complete. This PR allows users to obatin the original function signature when thedetail::unpack_callfails.cc @areusch