Skip to content

[Hexagon] Follow up fixes on PR #9631#10205

Merged
kparzysz-quic merged 1 commit into
apache:mainfrom
mehrdadh:hexagon/fix_rpc_server_issues
Feb 11, 2022
Merged

[Hexagon] Follow up fixes on PR #9631#10205
kparzysz-quic merged 1 commit into
apache:mainfrom
mehrdadh:hexagon/fix_rpc_server_issues

Conversation

@mehrdadh

@mehrdadh mehrdadh commented Feb 9, 2022

Copy link
Copy Markdown
Member

Follow up fixes on hexagon RPC server.

@mehrdadh

mehrdadh commented Feb 9, 2022

Copy link
Copy Markdown
Member Author

cc @kparzysz-quic

@tmoreau89 tmoreau89 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mehrdadh

@kparzysz-quic

kparzysz-quic commented Feb 11, 2022

Copy link
Copy Markdown
Contributor

In src/runtime/hexagon/rpc/hexagon/rpc_server.cc, line 198, you don't need to use new. You can statically allocate a local array (i.e. static uint8_t buffer[...]) and pass it to the server.

@kparzysz-quic kparzysz-quic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nitpick. It can be addressed later.

@kparzysz-quic kparzysz-quic merged commit c20cbc5 into apache:main Feb 11, 2022
@mehrdadh mehrdadh deleted the hexagon/fix_rpc_server_issues branch February 14, 2022 17:48
ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants