[Op][Topi] 5 ops can accept unsigned integers as indices#10098
Merged
Conversation
yuanfz98
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
Contributor
|
Debugging I've worked the issue to likely |
Contributor
|
#10102 <-- fix here. There is another error now with unravel index now though. You can try digging more, or you can drop unravel_index for later PR (which I recommend) |
AndrewZhaoLuo
left a comment
AndrewZhaoLuo
left a comment
Contributor
There was a problem hiding this comment.
LGTM mostly, just lmk the plan to deal with unravel_index
Contributor
Author
Thanks for your help! I prefer to drop unravel_index and open a PR later. |
…ops-indexing-support-uint
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* tests passed * reformat * add uint test for unravel_index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello community,
This PR links to #10064. 5 ops (scatter, scatter_add, scatter_nd, unravel_index, adv_index) accept unsigned integers as indices. Somehow unravel_index with uint indices may raise
in function
tvm/src/arith/const_int_bound.cc
Line 486 in e6af874
I tried to figure out why shape[v] can be 0 in
tvm/include/tvm/topi/transform.h
Line 383 in 7b9fd1e
but I failed to understand.
Thank reviewers for your help and your time speeding in CR.
cc @AndrewZhaoLuo