[MetaSchedule][M4a] Rewrite-Cooperative-Fetch#10081
Merged
Merged
Conversation
Hzfengsy
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen,
yzhliu and
zhiics
as code owners
62 tasks
Hzfengsy
changed the title
junrushao
changed the title
Member
|
Hey please rebase to the latest main |
Hzfengsy
force-pushed
the
rewrite-cooperative-fetch
branch
from
d90b791 to
4c3ba47
Compare
MasterJH5574
approved these changes
Jan 28, 2022
MasterJH5574
left a comment
MasterJH5574
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Only have some nits. Thank you Siyuan!
Hzfengsy
force-pushed
the
rewrite-cooperative-fetch
branch
from
4c3ba47 to
ce52b56
Compare
Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Xiyou Zhou <xiyou@octoml.ai> Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com> Co-authored-by: Hongyi Jin <3231950289@qq.com> Co-authored-by: Wuwei Lin <wuwei@apache.org>
Hzfengsy
force-pushed
the
rewrite-cooperative-fetch
branch
from
ce52b56 to
70c014e
Compare
spectrometerHBH
approved these changes
Jan 29, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Xiyou Zhou <xiyou@octoml.ai> Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com> Co-authored-by: Hongyi Jin <3231950289@qq.com> Co-authored-by: Wuwei Lin <wuwei@apache.org> Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Xiyou Zhou <xiyou@octoml.ai> Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com> Co-authored-by: Hongyi Jin <3231950289@qq.com> Co-authored-by: Wuwei Lin <wuwei@apache.org>
shingjan
reviewed
Mar 3, 2022
| tir::ParseThreadBinding(sch, inst, "threadIdx.y")) { | ||
| thread_extent_y = new_thread_extent.value()->value; | ||
| } else if (Optional<tir::BlockRV> block_rv = tir::ParseAnnotate(sch, inst, &vector_lane)) { | ||
| ICHECK_NE(thread_extent_x, -1); |
There was a problem hiding this comment.
is this check necessary here? I am hitting this check with a simple matmul_fp16 example with rules and postprocs like in test_meta_schedule_tune_tir and I wonder if more details about this check can be elaborated here.
Member
There was a problem hiding this comment.
it means threadIdx.x isn't bound in previous instructions, which isn't supposed to happen (and that's why it's an ICHECK instead of CHECK). Could you check the trace->insts and see why threadIdx.x doesn't exist previously
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is one of the PostProc for mate-schedule. Please see the tracking issue #8473
Co-authored-by: Junru Shao junrushao1994@gmail.com
Co-authored-by: Xiyou Zhou xiyou@octoml.ai
Co-authored-by: Bohan Hou 32121147+spectrometerHBH@users.noreply.github.com
Co-authored-by: Ruihang Lai lairuihangdongdong@qq.com
Co-authored-by: Hongyi Jin 3231950289@qq.com
Co-authored-by: Wuwei Lin wuwei@apache.org
cc @junrushao1994 @comaniac