Clean up certifier plugin debug messages. - #9975
Merged
Merged
Conversation
bneradt
requested changes
Jul 9, 2023
bneradt
left a comment
bneradt
left a comment
Contributor
There was a problem hiding this comment.
Thanks for cleaning this up.
@lzx404243 : can you review this too?
Contributor
|
Looks like the autest might need an expected log expression update: |
jpeach
force-pushed
the
certifier-log-msg
branch
from
July 10, 2023 09:25
e2d5773 to
d5036f6
Compare
Contributor
Author
|
[approve ci] |
lzx404243
requested changes
Jul 10, 2023
lzx404243
left a comment
lzx404243
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the clean up. Looks good overall. Some minor comments.
ywkaras
reviewed
Jul 10, 2023
ywkaras
reviewed
Jul 10, 2023
jpeach
force-pushed
the
certifier-log-msg
branch
from
July 11, 2023 00:04
d5036f6 to
ec67681
Compare
Contributor
Author
|
[approve ci] |
The certifier plugin manually write out the function name in debug messages, and these were wrong in some cases. Clean this up to use __func__ and a more consistent message format. Remove the "t" mode from fopen call, which is a Windows-ism. Signed-off-by: James Peach <jpeach@apache.org>
jpeach
force-pushed
the
certifier-log-msg
branch
from
July 11, 2023 09:10
ec67681 to
3038646
Compare
Contributor
|
[approve ci] |
|
@bneradt is this good now? |
bneradt
approved these changes
Aug 8, 2023
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: (221 commits) LSan: Fix leak of test_Metrics (apache#10179) LSan: Fix memory leak of test_EventSystem (apache#10178) LSan: Fix memory leak of test_X509HostnameValidator (apache#10161) Remove cqtx log field (apache#10111) Require ATS plugins to be compiled with C++17. (apache#10007) Fix conf_remap plugin build on macOS (apache#10177) libswoc: Update to 1.5.4 (apache#10155) Makes cmake build again, on macOS (apache#10172) Check SNI in h3 (apache#10184) Remove autoconf headers during CMake configuration (apache#10173) test_QUICLossDetector.cc: Add back get_hrtime() (apache#10185) ink_ink_get_hrtime -> ink_get_hrtime (apache#10182) mgmt: make libconfigmanager a true static library (apache#10181) Make sure that the thread local time is updated timely (apache#10163) Unrequire remap rules for OCSP (apache#10146) cache_range test performance improvement (apache#10170) Clean up certifier plugin debug messages. (apache#9975) cmake: add check for clock_gettime (apache#10169) Remove Http3NoError allocations (apache#10165) Fix Throttler initialization. (apache#10154) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The certifier plugin manually write out the function name in debug messages, and these were wrong in some cases. Clean this up to use func and a more consistent message format. Remove the "t" mode from fopen call, which is a Windows-ism.