Clean RefCountObj - #9217
Merged
Merged
Conversation
cukiernik
force-pushed
the
RefCountObj
branch
from
November 23, 2022 14:55
6635090 to
fcd44e4
Compare
cukiernik
marked this pull request as ready for review
November 23, 2022 14:58
|
Can you also do the same thing to the assignment operator? |
Contributor
|
Should the copy constructor and assignment be marked |
|
@cmcfarlen the copy is OK, because the ref count will be set to zero. But for assign, the ref count should not be set to zero. |
bryancall
approved these changes
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.