Skip to content

Apple Silicon macOS support - #7389

Merged
randall merged 1 commit into
apache:masterfrom
randall:macos_darwin
Feb 16, 2021
Merged

Apple Silicon macOS support#7389
randall merged 1 commit into
apache:masterfrom
randall:macos_darwin

Conversation

@randall

@randall randall commented Dec 15, 2020

Copy link
Copy Markdown
Contributor

Allows builds on Apple Silicon to complete and run

@randall randall added the Build work related to build configuration or environment label Dec 15, 2020
@randall randall added this to the 10.0.0 milestone Dec 15, 2020
@randall
randall force-pushed the macos_darwin branch 2 times, most recently from 41d650b to c81bb76 Compare December 30, 2020 00:21
@randall randall changed the title Disable compiling Inline.cc on macOS Apple Silicon macOS support Dec 30, 2020
@randall randall self-assigned this Jan 6, 2021
@ywkaras

ywkaras commented Jan 9, 2021

Copy link
Copy Markdown

I am confused that there are changes to catch.hpp but no change to the version, how is that possible?

3 similar comments
@ywkaras

This comment has been minimized.

@ywkaras

This comment has been minimized.

@ywkaras

ywkaras commented Jan 9, 2021

Copy link
Copy Markdown

I am confused that there are changes to catch.hpp but no change to the version, how is that possible?

@randall

randall commented Feb 1, 2021

Copy link
Copy Markdown
Contributor Author

I am confused that there are changes to catch.hpp but no change to the version, how is that possible?

I manually back ported the apple-related changes from catch.

Upgrading catch to it's latest version is an effort of it's own: #7464

@bryancall

Copy link
Copy Markdown
Contributor

@randall Can you have a better explanation of what is happening? We did a code review today and had questions.

Allows builds on Apple Silicon to complete and run
@randall

randall commented Feb 12, 2021

Copy link
Copy Markdown
Contributor Author

originally, I back ported some macOS specific changes from catch.hpp's head to get macOS on AS to build. With #7464 merged I no longer need that (and this PR has been fixed up to reflect that)

@apache apache deleted a comment from bneradt Feb 16, 2021
@randall
randall merged commit fa8b3f9 into apache:master Feb 16, 2021
@randall
randall deleted the macos_darwin branch February 16, 2021 20:28
@zwoop

zwoop commented Feb 23, 2021

Copy link
Copy Markdown
Contributor

Cherry-picked to v9.1.x branch.

@zwoop zwoop modified the milestones: 10.0.0, 9.1.0 Feb 23, 2021
@zwoop

zwoop commented Feb 23, 2021

Copy link
Copy Markdown
Contributor

Cherry-picked to v9.0.x branch.

@zwoop zwoop modified the milestones: 9.1.0, 9.0.1 Feb 23, 2021
@zwoop

zwoop commented Mar 9, 2021

Copy link
Copy Markdown
Contributor

I think we need to revert this for now, from all release branches.

@zwoop zwoop modified the milestones: 9.0.1, 10.0.0 Mar 9, 2021
@zwoop zwoop modified the milestones: 10.0.0, 9.1.0 May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build work related to build configuration or environment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants